New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use select instead of timeouts #3

Open

awilfox opened this issue Nov 1, 2014 · 0 comments

Labels

Member

awilfox commented Nov 1, 2014

also, the read loops and write loops are duplication and unnecessary.

POST's read loop doesn't check for NULL on realloc, potentially segfaulting.
GET's read loop doesn't check for purposeful cancellation and treats that as an error condition
GET's write loop doesn't report errors if they occur, just return NULL

it's all broken crap and needs major refactoring.

awilfox added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment