From daf56ce213a990175ba53fae37f6b4c6092f7074 Mon Sep 17 00:00:00 2001 From: Lucas Werkmeister Date: Mon, 16 Dec 2024 10:56:35 +0100 Subject: [PATCH] Kick bundlesize out of package.json MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This pulled in ancient versions of brotli-size (unlikely to be fixed: https://github.com/siddharthkp/bundlesize/pull/370#issuecomment-1038968845) which broke CI on Node 20. IIUC, it shouldn’t even be needed anymore now that bundle size can be tested via BundleSizeTestBase instead; but in any case this can be figured out later, *after* CI is restored for the many extensions that pull in Popups. Bug: T382192 Bug: T360590 Change-Id: I86413a7707cbd33fd473f8a1daf6c7866fbb473f (cherry picked from commit 300e32b4d83070572812f094bd060dfd69d37362) --- package-lock.json | 610 ---------------------------------------------- package.json | 3 +- 2 files changed, 1 insertion(+), 612 deletions(-) diff --git a/package-lock.json b/package-lock.json index 0d198ca9..4229d5a6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -22,7 +22,6 @@ "@wikimedia/mw-node-qunit": "7.0.0", "babel-loader": "9.1.3", "browserslist-config-wikimedia": "0.2.0", - "bundlesize": "0.18.2", "clean-webpack-plugin": "3.0.0", "cssjanus": "1.3.1", "eslint": "8.31.0", @@ -3139,11 +3138,6 @@ "node": ">=8" } }, - "node_modules/aproba": { - "version": "1.2.0", - "dev": true, - "license": "ISC" - }, "node_modules/archiver": { "version": "5.3.1", "dev": true, @@ -3199,15 +3193,6 @@ "dev": true, "license": "MIT" }, - "node_modules/are-we-there-yet": { - "version": "1.1.7", - "dev": true, - "license": "ISC", - "dependencies": { - "delegates": "^1.0.0", - "readable-stream": "^2.0.6" - } - }, "node_modules/argparse": { "version": "2.0.1", "dev": true, @@ -3319,17 +3304,6 @@ "dev": true, "license": "MIT" }, - "node_modules/axios": { - "version": "1.7.5", - "resolved": "https://registry.npmjs.org/axios/-/axios-1.7.5.tgz", - "integrity": "sha512-fZu86yCo+svH3uqJ/yTdQ0QHpQu5oL+/QE+QPSv6BZSkDAoky9vytxp7u5qk83OJFS3kEBcesWni9WTZAv3tSw==", - "dev": true, - "dependencies": { - "follow-redirects": "^1.15.6", - "form-data": "^4.0.0", - "proxy-from-env": "^1.1.0" - } - }, "node_modules/babel-loader": { "version": "9.1.3", "dev": true, @@ -3724,18 +3698,6 @@ "node": ">=8" } }, - "node_modules/brotli-size": { - "version": "0.1.0", - "dev": true, - "license": "MIT", - "dependencies": { - "duplexer": "^0.1.1", - "iltorb": "^2.4.3" - }, - "engines": { - "node": ">=0.12.0" - } - }, "node_modules/browser-process-hrtime": { "version": "1.0.0", "dev": true, @@ -3831,103 +3793,6 @@ "url": "https://github.com/sponsors/sindresorhus" } }, - "node_modules/bundlesize": { - "version": "0.18.2", - "resolved": "https://registry.npmjs.org/bundlesize/-/bundlesize-0.18.2.tgz", - "integrity": "sha512-wthRURckcAbe0Qcr7xMH8evVE/kjID8gqY0M17XJI/FVgCljLx6Ag4lIDbV76KVb2Ey5iCA4n5Fur61TEhF1JQ==", - "dev": true, - "dependencies": { - "axios": "^1.6.2", - "brotli-size": "0.1.0", - "bytes": "^3.1.0", - "ci-env": "^1.4.0", - "commander": "^2.20.0", - "cosmiconfig": "^5.2.1", - "github-build": "^1.2.4", - "glob": "^7.1.4", - "gzip-size": "^4.0.0", - "prettycli": "^1.4.3" - }, - "bin": { - "bundlesize": "index.js", - "bundlesize-init": "src/init-status.js", - "bundlesize-pipe": "pipe.js" - } - }, - "node_modules/bundlesize/node_modules/argparse": { - "version": "1.0.10", - "dev": true, - "license": "MIT", - "dependencies": { - "sprintf-js": "~1.0.2" - } - }, - "node_modules/bundlesize/node_modules/cosmiconfig": { - "version": "5.2.1", - "dev": true, - "license": "MIT", - "dependencies": { - "import-fresh": "^2.0.0", - "is-directory": "^0.3.1", - "js-yaml": "^3.13.1", - "parse-json": "^4.0.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/bundlesize/node_modules/import-fresh": { - "version": "2.0.0", - "dev": true, - "license": "MIT", - "dependencies": { - "caller-path": "^2.0.0", - "resolve-from": "^3.0.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/bundlesize/node_modules/js-yaml": { - "version": "3.14.1", - "dev": true, - "license": "MIT", - "dependencies": { - "argparse": "^1.0.7", - "esprima": "^4.0.0" - }, - "bin": { - "js-yaml": "bin/js-yaml.js" - } - }, - "node_modules/bundlesize/node_modules/parse-json": { - "version": "4.0.0", - "dev": true, - "license": "MIT", - "dependencies": { - "error-ex": "^1.3.1", - "json-parse-better-errors": "^1.0.1" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/bundlesize/node_modules/resolve-from": { - "version": "3.0.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=4" - } - }, - "node_modules/bytes": { - "version": "3.1.2", - "dev": true, - "license": "MIT", - "engines": { - "node": ">= 0.8" - } - }, "node_modules/cac": { "version": "3.0.4", "dev": true, @@ -4151,36 +4016,6 @@ "url": "https://github.com/sponsors/ljharb" } }, - "node_modules/caller-callsite": { - "version": "2.0.0", - "dev": true, - "license": "MIT", - "dependencies": { - "callsites": "^2.0.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/caller-callsite/node_modules/callsites": { - "version": "2.0.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=4" - } - }, - "node_modules/caller-path": { - "version": "2.0.0", - "dev": true, - "license": "MIT", - "dependencies": { - "caller-callsite": "^2.0.0" - }, - "engines": { - "node": ">=4" - } - }, "node_modules/callsites": { "version": "3.1.0", "dev": true, @@ -4355,11 +4190,6 @@ "node": ">=6.0" } }, - "node_modules/ci-env": { - "version": "1.17.0", - "dev": true, - "license": "MIT" - }, "node_modules/ci-info": { "version": "3.9.0", "dev": true, @@ -4484,14 +4314,6 @@ "url": "https://github.com/sponsors/sindresorhus" } }, - "node_modules/code-point-at": { - "version": "1.1.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=0.10.0" - } - }, "node_modules/color-convert": { "version": "2.0.1", "dev": true, @@ -4615,11 +4437,6 @@ "typedarray": "^0.0.6" } }, - "node_modules/console-control-strings": { - "version": "1.1.0", - "dev": true, - "license": "ISC" - }, "node_modules/convert-source-map": { "version": "1.8.0", "dev": true, @@ -5005,14 +4822,6 @@ "url": "https://github.com/sponsors/sindresorhus" } }, - "node_modules/deep-extend": { - "version": "0.6.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=4.0.0" - } - }, "node_modules/deep-is": { "version": "0.1.4", "dev": true, @@ -5131,11 +4940,6 @@ "node": ">=0.4.0" } }, - "node_modules/delegates": { - "version": "1.0.0", - "dev": true, - "license": "MIT" - }, "node_modules/dequal": { "version": "2.0.3", "dev": true, @@ -5144,17 +4948,6 @@ "node": ">=6" } }, - "node_modules/detect-libc": { - "version": "1.0.3", - "dev": true, - "license": "Apache-2.0", - "bin": { - "detect-libc": "bin/detect-libc.js" - }, - "engines": { - "node": ">=0.10" - } - }, "node_modules/devtools": { "version": "7.30.0", "dev": true, @@ -5287,11 +5080,6 @@ "node": ">=12" } }, - "node_modules/duplexer": { - "version": "0.1.2", - "dev": true, - "license": "MIT" - }, "node_modules/duplexer2": { "version": "0.0.2", "dev": true, @@ -6230,14 +6018,6 @@ "dev": true, "license": "ISC" }, - "node_modules/expand-template": { - "version": "2.0.3", - "dev": true, - "license": "(MIT OR WTFPL)", - "engines": { - "node": ">=6" - } - }, "node_modules/expect": { "version": "28.1.3", "dev": true, @@ -6579,26 +6359,6 @@ "dev": true, "license": "ISC" }, - "node_modules/follow-redirects": { - "version": "1.15.6", - "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.6.tgz", - "integrity": "sha512-wWN62YITEaOpSK584EZXJafH1AGpO8RVgElfkuXbTOrPX4fIfOyEpW/CsiNd8JdYrAoOvafRTOEnvsO++qCqFA==", - "dev": true, - "funding": [ - { - "type": "individual", - "url": "https://github.com/sponsors/RubenVerborgh" - } - ], - "engines": { - "node": ">=4.0" - }, - "peerDependenciesMeta": { - "debug": { - "optional": true - } - } - }, "node_modules/foreground-child": { "version": "2.0.0", "dev": true, @@ -6669,64 +6429,6 @@ "url": "https://github.com/sponsors/ljharb" } }, - "node_modules/gauge": { - "version": "2.7.4", - "dev": true, - "license": "ISC", - "dependencies": { - "aproba": "^1.0.3", - "console-control-strings": "^1.0.0", - "has-unicode": "^2.0.0", - "object-assign": "^4.1.0", - "signal-exit": "^3.0.0", - "string-width": "^1.0.1", - "strip-ansi": "^3.0.1", - "wide-align": "^1.1.0" - } - }, - "node_modules/gauge/node_modules/ansi-regex": { - "version": "2.1.1", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=0.10.0" - } - }, - "node_modules/gauge/node_modules/is-fullwidth-code-point": { - "version": "1.0.0", - "dev": true, - "license": "MIT", - "dependencies": { - "number-is-nan": "^1.0.0" - }, - "engines": { - "node": ">=0.10.0" - } - }, - "node_modules/gauge/node_modules/string-width": { - "version": "1.0.2", - "dev": true, - "license": "MIT", - "dependencies": { - "code-point-at": "^1.0.0", - "is-fullwidth-code-point": "^1.0.0", - "strip-ansi": "^3.0.0" - }, - "engines": { - "node": ">=0.10.0" - } - }, - "node_modules/gauge/node_modules/strip-ansi": { - "version": "3.0.1", - "dev": true, - "license": "MIT", - "dependencies": { - "ansi-regex": "^2.0.0" - }, - "engines": { - "node": ">=0.10.0" - } - }, "node_modules/gaze": { "version": "1.1.3", "dev": true, @@ -6797,29 +6499,6 @@ "assert-plus": "^1.0.0" } }, - "node_modules/github-build": { - "version": "1.2.4", - "dev": true, - "license": "MIT", - "dependencies": { - "axios": "1.6.0" - } - }, - "node_modules/github-build/node_modules/axios": { - "version": "1.6.0", - "dev": true, - "license": "MIT", - "dependencies": { - "follow-redirects": "^1.15.0", - "form-data": "^4.0.0", - "proxy-from-env": "^1.1.0" - } - }, - "node_modules/github-from-package": { - "version": "0.0.0", - "dev": true, - "license": "MIT" - }, "node_modules/glob": { "version": "7.2.0", "dev": true, @@ -7031,26 +6710,6 @@ "node": ">=8" } }, - "node_modules/gzip-size": { - "version": "4.1.0", - "dev": true, - "license": "MIT", - "dependencies": { - "duplexer": "^0.1.1", - "pify": "^3.0.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/gzip-size/node_modules/pify": { - "version": "3.0.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=4" - } - }, "node_modules/har-schema": { "version": "2.0.0", "dev": true, @@ -7129,11 +6788,6 @@ "url": "https://github.com/sponsors/ljharb" } }, - "node_modules/has-unicode": { - "version": "2.0.1", - "dev": true, - "license": "ISC" - }, "node_modules/hasha": { "version": "5.2.2", "dev": true, @@ -7302,19 +6956,6 @@ "node": ">= 4" } }, - "node_modules/iltorb": { - "version": "2.4.5", - "dev": true, - "hasInstallScript": true, - "license": "MIT", - "dependencies": { - "detect-libc": "^1.0.3", - "nan": "^2.14.0", - "npmlog": "^4.1.2", - "prebuild-install": "^5.3.3", - "which-pm-runs": "^1.0.0" - } - }, "node_modules/image-size": { "version": "0.5.5", "dev": true, @@ -7542,14 +7183,6 @@ "url": "https://github.com/sponsors/ljharb" } }, - "node_modules/is-directory": { - "version": "0.3.1", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=0.10.0" - } - }, "node_modules/is-docker": { "version": "2.2.1", "dev": true, @@ -8409,11 +8042,6 @@ "dev": true, "license": "MIT" }, - "node_modules/json-parse-better-errors": { - "version": "1.0.2", - "dev": true, - "license": "MIT" - }, "node_modules/json-parse-even-better-errors": { "version": "2.3.1", "dev": true, @@ -9510,11 +9138,6 @@ "node": ">=10" } }, - "node_modules/nan": { - "version": "2.15.0", - "dev": true, - "license": "MIT" - }, "node_modules/nanoid": { "version": "3.3.3", "dev": true, @@ -9526,11 +9149,6 @@ "node": "^10 || ^12 || ^13.7 || ^14 || >=15.0.1" } }, - "node_modules/napi-build-utils": { - "version": "1.0.2", - "dev": true, - "license": "MIT" - }, "node_modules/native-request": { "version": "1.1.0", "dev": true, @@ -9559,14 +9177,6 @@ "path-to-regexp": "^1.7.0" } }, - "node_modules/node-abi": { - "version": "2.30.1", - "dev": true, - "license": "MIT", - "dependencies": { - "semver": "^5.4.1" - } - }, "node_modules/node-fetch": { "version": "2.6.7", "dev": true, @@ -9629,11 +9239,6 @@ "node": ">=6" } }, - "node_modules/noop-logger": { - "version": "0.1.1", - "dev": true, - "license": "MIT" - }, "node_modules/normalize-package-data": { "version": "2.5.0", "dev": true, @@ -9664,17 +9269,6 @@ "url": "https://github.com/sponsors/sindresorhus" } }, - "node_modules/npmlog": { - "version": "4.1.2", - "dev": true, - "license": "ISC", - "dependencies": { - "are-we-there-yet": "~1.1.2", - "console-control-strings": "~1.1.0", - "gauge": "~2.7.3", - "set-blocking": "~2.0.0" - } - }, "node_modules/nth-check": { "version": "2.1.1", "dev": true, @@ -9686,14 +9280,6 @@ "url": "https://github.com/fb55/nth-check?sponsor=1" } }, - "node_modules/number-is-nan": { - "version": "1.0.1", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=0.10.0" - } - }, "node_modules/nwsapi": { "version": "2.2.0", "dev": true, @@ -10639,34 +10225,6 @@ "dev": true, "license": "ISC" }, - "node_modules/prebuild-install": { - "version": "5.3.6", - "dev": true, - "license": "MIT", - "dependencies": { - "detect-libc": "^1.0.3", - "expand-template": "^2.0.3", - "github-from-package": "0.0.0", - "minimist": "^1.2.3", - "mkdirp-classic": "^0.5.3", - "napi-build-utils": "^1.0.1", - "node-abi": "^2.7.0", - "noop-logger": "^0.1.1", - "npmlog": "^4.0.1", - "pump": "^3.0.0", - "rc": "^1.2.7", - "simple-get": "^3.0.3", - "tar-fs": "^2.0.0", - "tunnel-agent": "^0.6.0", - "which-pm-runs": "^1.0.0" - }, - "bin": { - "prebuild-install": "bin.js" - }, - "engines": { - "node": ">=6" - } - }, "node_modules/prelude-ls": { "version": "1.2.1", "dev": true, @@ -10730,46 +10288,6 @@ "url": "https://github.com/sponsors/sindresorhus" } }, - "node_modules/prettycli": { - "version": "1.4.3", - "dev": true, - "license": "MIT", - "dependencies": { - "chalk": "2.1.0" - } - }, - "node_modules/prettycli/node_modules/chalk": { - "version": "2.1.0", - "dev": true, - "license": "MIT", - "dependencies": { - "ansi-styles": "^3.1.0", - "escape-string-regexp": "^1.0.5", - "supports-color": "^4.0.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/prettycli/node_modules/has-flag": { - "version": "2.0.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=0.10.0" - } - }, - "node_modules/prettycli/node_modules/supports-color": { - "version": "4.5.0", - "dev": true, - "license": "MIT", - "dependencies": { - "has-flag": "^2.0.0" - }, - "engines": { - "node": ">=4" - } - }, "node_modules/prettyjson": { "version": "1.2.5", "dev": true, @@ -10963,28 +10481,6 @@ "safe-buffer": "^5.1.0" } }, - "node_modules/rc": { - "version": "1.2.8", - "dev": true, - "license": "(BSD-2-Clause OR MIT OR Apache-2.0)", - "dependencies": { - "deep-extend": "^0.6.0", - "ini": "~1.3.0", - "minimist": "^1.2.0", - "strip-json-comments": "~2.0.1" - }, - "bin": { - "rc": "cli.js" - } - }, - "node_modules/rc/node_modules/strip-json-comments": { - "version": "2.0.1", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=0.10.0" - } - }, "node_modules/read-pkg": { "version": "5.2.0", "resolved": "https://registry.npmjs.org/read-pkg/-/read-pkg-5.2.0.tgz", @@ -11713,57 +11209,6 @@ "dev": true, "license": "ISC" }, - "node_modules/simple-concat": { - "version": "1.0.1", - "dev": true, - "funding": [ - { - "type": "github", - "url": "https://github.com/sponsors/feross" - }, - { - "type": "patreon", - "url": "https://www.patreon.com/feross" - }, - { - "type": "consulting", - "url": "https://feross.org/support" - } - ], - "license": "MIT" - }, - "node_modules/simple-get": { - "version": "3.1.1", - "dev": true, - "license": "MIT", - "dependencies": { - "decompress-response": "^4.2.0", - "once": "^1.3.1", - "simple-concat": "^1.0.0" - } - }, - "node_modules/simple-get/node_modules/decompress-response": { - "version": "4.2.1", - "dev": true, - "license": "MIT", - "dependencies": { - "mimic-response": "^2.0.0" - }, - "engines": { - "node": ">=8" - } - }, - "node_modules/simple-get/node_modules/mimic-response": { - "version": "2.1.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=8" - }, - "funding": { - "url": "https://github.com/sponsors/sindresorhus" - } - }, "node_modules/simple-html-tokenizer": { "version": "0.1.1", "dev": true, @@ -13495,61 +12940,6 @@ "dev": true, "license": "ISC" }, - "node_modules/which-pm-runs": { - "version": "1.1.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=4" - } - }, - "node_modules/wide-align": { - "version": "1.1.3", - "dev": true, - "license": "ISC", - "dependencies": { - "string-width": "^1.0.2 || 2" - } - }, - "node_modules/wide-align/node_modules/ansi-regex": { - "version": "3.0.1", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=4" - } - }, - "node_modules/wide-align/node_modules/is-fullwidth-code-point": { - "version": "2.0.0", - "dev": true, - "license": "MIT", - "engines": { - "node": ">=4" - } - }, - "node_modules/wide-align/node_modules/string-width": { - "version": "2.1.1", - "dev": true, - "license": "MIT", - "dependencies": { - "is-fullwidth-code-point": "^2.0.0", - "strip-ansi": "^4.0.0" - }, - "engines": { - "node": ">=4" - } - }, - "node_modules/wide-align/node_modules/strip-ansi": { - "version": "4.0.0", - "dev": true, - "license": "MIT", - "dependencies": { - "ansi-regex": "^3.0.0" - }, - "engines": { - "node": ">=4" - } - }, "node_modules/wildcard": { "version": "2.0.1", "dev": true, diff --git a/package.json b/package.json index 3a01ff16..071804dd 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "build-storybook": "./.storybook/storybook-resources.sh && build-storybook --config-dir=.storybook -o docs/ui -s .storybook/static", "start": "webpack -w --mode=development", "build": "webpack --mode=production", - "test": "npm -s run check-built-assets && npm run test:lint && bash ./dev-scripts/svg_check.sh && npm -s run coverage && npm -s run doc && bundlesize", + "test": "npm -s run check-built-assets && npm run test:lint && bash ./dev-scripts/svg_check.sh && npm -s run coverage && npm -s run doc", "test:unit": "mw-node-qunit \"tests/node-qunit/**/*.test.js\" --require \"$PWD/tests/node-qunit/run.js\" | tap-mocha-reporter dot", "test:lint": "npm -s run test:lint:styles && npm -s run test:lint:js && npm -s run test:lint:i18n", "test:lint:js": "npm -s run linter:js", @@ -43,7 +43,6 @@ "@wikimedia/mw-node-qunit": "7.0.0", "babel-loader": "9.1.3", "browserslist-config-wikimedia": "0.2.0", - "bundlesize": "0.18.2", "clean-webpack-plugin": "3.0.0", "cssjanus": "1.3.1", "eslint": "8.31.0",