Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp_utils missing #3

Open
steven-varga opened this issue Mar 2, 2018 · 5 comments
Open

cpp_utils missing #3

steven-varga opened this issue Mar 2, 2018 · 5 comments

Comments

@steven-varga
Copy link

The library seem to be missing some parts:
/usr/local/include/etl/std.hpp:21:32: fatal error: cpp_utils/compat.hpp: No such file or directory
from "/etl/std.hpp" the inclusions are not provided
....
// cpp_utils
#include "cpp_utils/compat.hpp"
#include "cpp_utils/tmp.hpp"
#include "cpp_utils/likely.hpp"
#include "cpp_utils/assert.hpp"
#include "cpp_utils/parallel.hpp"

investingating source tree, no files in git directory.

Method of installation:
git clone https://github.com/wichtounet/etl.git
cp -R etl /usr/local/lib

@wichtounet
Copy link
Owner

wichtounet commented Mar 5, 2018

Hello,

cpp_utils is a sub module, therefore, you need to do a recursive clone:

git clone --recursive https://github.com/wichtounet/etl.git

I also recommend only copying the headers:

cp -R etl/include /usr/local/lib/include/
cp -R lib/include /usr/local/lib/include/

I hope that helps :)

@josephjaspers
Copy link

used git clone --recursive, same issue.

@wichtounet
Copy link
Owner

Hi @josephjaspers

Sorry about that.

Do you a lib/include/cpp_utils directory in the directory you clone with --recursive ?

Can you give me the command you are using for compiling and the error ?

Thanks

@josephjaspers
Copy link

I simply used:

git clone --recursive
found the issue, you must include both the:

etl/include
AND
etl/lib/include

This seems counter-intuitive to a header-library. Why not put the etl/lib directory into the etl/lib directory so users won't need to include these two directories separately?

@wichtounet
Copy link
Owner

You are right, you need both. I forgot to mention this in the Readme. I fixed it. Thanks :)

I didn't want to fix the dependencies of the library with the library. But this may not be ideal indeed as you pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants