Resolve #6 by adding settings via presets #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adresses issue wichmann-lab#6: Additional settings can now be adjusted. Implemented by creating and applying develop presets. For now, only added "dehaze" and "texture" to the table of available settings. In principle, this should work for all settings that are listed in the GUI when applying a develop preset.
|
I want to perform one more check whether the new functions work as intended, so better wait with the merge. |
just get back to me when it's ready |
Changes via presets (i.e. texture and dehaze) were not actually applied due to faulty creation of the table of settings used to create the preset.
|
There actually was a bug in the last version, I fixed it in the recent commit. Now ready for merging. |
|
Added a fix that solves #8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a list of settings that are not available via quick develop, for now containing texture and dehaze. Upon editing a photo (and resetting the values at the end), check for each setting whether it is in this list. If so, adjust it by creating and applying a develop preset.