Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard_parameters will fail when alpha==0 #175

Open
pberkes opened this issue Nov 28, 2024 · 0 comments
Open

standard_parameters will fail when alpha==0 #175

pberkes opened this issue Nov 28, 2024 · 0 comments
Milestone

Comments

@pberkes
Copy link
Collaborator

pberkes commented Nov 28, 2024

I forgot to test for the corner case / not unlikely case when alpha is exactly 0.0 .
The standard_parameters method will fail for those cases, because the rescaling will give inifinities and nans.

other stuff would have failed also before #169, for example in the Logistic sigmoid we had
C = 2 * np.log(1 / self.alpha - 1) / width
which is going to cause a division by zero.

@pberkes pberkes added this to the v4.3 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant