-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cache restore bug in gh issue #1377 by fixing paths #15
Fix cache restore bug in gh issue #1377 by fixing paths #15
Conversation
@whywaita please review. |
@whywaita Were you able to review? I see the check dist CI step failing but assuming it's not related to this PR. Thanks! |
I will review it. But We need to fix CI in this pr. |
@devsh4 Did you write a comment under
|
@whywaita my bad, that was a bad copy/paste and I thought I pushed the commit. Should be good now. |
6be557d
to
c56a799
Compare
c56a799
to
289f2b2
Compare
Previous messageThanks for this, @devsh4. Is this fix working for y'all? I pointed my GitHub workflow to your fork to try it, but I still see "not found" failures like this
even though the "v1-Linux-ARM64-8ece81f19f8907841274feda72820220bb97cc28784a63e9ef9b00aea8729635" does in fact exist in the S3 bucket. I cannot tell if this is the bug or not. EDIT: Nevermind, I realize I was hitting a different issue, and have opened this PR: whywaita/actions-toolkit-s3#11 |
@whywaita any concerns or is this PR good to merge? |
Sorry late. Thank you! |
There's an open issue in @actions/toolkit that uncovers a major bug with cache restores not working after v3.1.1 of @actions/cache.
On attempting to upgrade and use v3-s3 of this action, we ran into similar issues and the below PR is to fix the underlying issue until the upstream PR is merged.
Description
Types of changes
Checklist: