From 1b6a83c89d75be8a4cf16608c9c4215ab7e4be04 Mon Sep 17 00:00:00 2001 From: sergeichestakov Date: Fri, 14 Jun 2024 18:37:18 -0400 Subject: [PATCH 1/2] Limit length of PR body to GH maximum --- packages/action/src/util/get-message.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/action/src/util/get-message.ts b/packages/action/src/util/get-message.ts index e5608eb..75adedb 100644 --- a/packages/action/src/util/get-message.ts +++ b/packages/action/src/util/get-message.ts @@ -7,6 +7,9 @@ import { ReleaseStats } from './types'; const capitalise = (str: string) => `${str.at(0)?.toUpperCase() || ''}${str.slice(1)}`; +// GitHub enforces a max length of 65536 characters for a pull request body +const maxLength = 65536; + export const makeGithubReleaseMessage = (stats: ReleaseStats) => ` ${Object.entries(stats.pulls) @@ -22,7 +25,9 @@ ${pulls.map(({ title }) => `- ${title}`).join('\n')} ${Array.from(stats.authors) .map((author) => `@${author}`) .join(', ')} -`.trim(); +` + .trim() + .slice(0, maxLength); const getReleaseMessage = async (prerelease: boolean) => { const latestRelease = await getLatestRelease(prerelease); From 08897fcebf8c2c4d5ac8ae66008ab6c19ba4b0ee Mon Sep 17 00:00:00 2001 From: sergeichestakov Date: Sat, 15 Jun 2024 17:20:40 -0400 Subject: [PATCH 2/2] Try pinning eslint version --- .github/workflows/pull.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml index 1521273..d6cb519 100644 --- a/.github/workflows/pull.yml +++ b/.github/workflows/pull.yml @@ -60,7 +60,7 @@ jobs: - name: Install all packages run: pnpm install - name: Run eslint - run: pnpx eslint ./ --max-warnings 0 + run: pnpx eslint@8.57.0 ./ --max-warnings 0 build: name: Build packages