Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suffixList.isRegistrable("bad.bad") returns true #9

Open
kamal2311 opened this issue Mar 30, 2016 · 2 comments
Open

suffixList.isRegistrable("bad.bad") returns true #9

kamal2311 opened this issue Mar 30, 2016 · 2 comments

Comments

@kamal2311
Copy link

suffixList.isRegistrable("bad.bad") returns true -> though bad is not in the suffix list
suffixList.isRegistrable("co m") returns true -> though co m is invalid altogether.

Can you please check?

@malkusch
Copy link
Member

bad is not in the suffix list

It is implicit. Check the PSL algorithm:

If no rules match, the prevailing rule is "*".

co m is invalid altogether.

Yeah, this is a similar issue like #8.

@idelpivnitskiy
Copy link

@malkusch Yes, according to the PSL algorithm it's correct. But one of the most useful features is to check is the TLD in the PSL or not. What about introducing a separate method or param, which will exclude wildcard from the rules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants