Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubycritic Gem installation Failed #477

Closed
abhikanojia opened this issue Jan 2, 2024 · 2 comments
Closed

Rubycritic Gem installation Failed #477

abhikanojia opened this issue Jan 2, 2024 · 2 comments

Comments

@abhikanojia
Copy link

Rubycritic gem installation is failing.
Upon investigating further I found that it is due to reek version got updated recently

https://rubygems.org/gems/reek

Reek is now at 6.2.0 unlike 6.1.4 where it used to work fine.

image
@nunosilva800
Copy link
Collaborator

nunosilva800 commented Jan 2, 2024

The gemspec for reek is '~> 6.0', '< 7.0'.
You should be able to set your gemfile to gem reek, '< 6.2' and get a successful installation.

The only other thing we might want to do is to push a patch for version 4.7.1 that constrains reek version and/or further restricks required_ruby_version .

Of course the best thing you can do is to upgrade the ruby installation to a version that is still maintained.

@etagwerker
Copy link
Collaborator

This works for me with this version: rubycritic-4.9.0

At the same time I think it'd be a good idea to drop support for Ruby 2.7 and follow reek's lead on requiring Ruby 3.0 or higher. We can continue that conversation over here: #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants