Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with ScalaTest's AsyncTestSuite #135

Open
shawjef3 opened this issue Jan 26, 2020 · 0 comments
Open

Incompatible with ScalaTest's AsyncTestSuite #135

shawjef3 opened this issue Jan 26, 2020 · 0 comments

Comments

@shawjef3
Copy link

DockerKit has an implicit ExecutionContext, which along with the one in ScalaTest's AsyncTestSuite causes an ambiguity error. Since DockerKit's ExecutionContext is really only for its own internal calls, it should be made private.

Error:(16, 34) ambiguous implicit values:
 both method executionContext in trait AsyncTestSuite of type => scala.concurrent.ExecutionContext
 and value dockerExecutionContext in trait DockerKit of type => scala.concurrent.ExecutionContext
 match expected type scala.concurrent.ExecutionContext

A workaround is to have each class that uses them provide a disambiguating ExecutionContext. I don't see this as a good solution though, since I expect clients of DockerKit shouldn't be given the option of using its internal ExecutionContext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant