Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Support #12

Open
leotada opened this issue Feb 22, 2018 · 4 comments
Open

Python 3 Support #12

leotada opened this issue Feb 22, 2018 · 4 comments

Comments

@leotada
Copy link
Contributor

leotada commented Feb 22, 2018

This needs a Python 3 support. I can help.

@leotada
Copy link
Contributor Author

leotada commented Feb 22, 2018

I done this here: https://github.com/leotada/koparka/tree/py3

@wezu
Copy link
Owner

wezu commented Feb 23, 2018

I will accept pull requests, but please make sure it will still work on py2. So I'd rather see basestring defined as basestring=str on py3 then just replacing basestring with str. I'm also not 100% sure how py2 likes explicit relative imports - I've seen 2to3 add leading dots to the imports in demo.py, but demo.py is not part of a package, you should not import it, just run it, so I don't think the relative imports are needed here.

@leotada
Copy link
Contributor Author

leotada commented Jun 10, 2018

#14

@wezu
Copy link
Owner

wezu commented Jun 10, 2018

It looks good, I don't see anything that should make problems, but I admit I haven't yet tested it on py 2.7 and py 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants