Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color_scheme: rose-pine-moon selected_bg is the same color as background - impossible to see what is selected #6118

Closed
mayboroda opened this issue Sep 10, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@mayboroda
Copy link

mayboroda commented Sep 10, 2024

What Operating System(s) are you seeing this problem on?

macOS

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20240812-215703-30345b36

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

When I use color_scheme = "rose-pine-moon" or any other rose-pine color scheme I can't see selection area during copy-mode, because background color and selection_bg color is identical, at lease here

To Reproduce

  • Install latest nightly build
  • set color_scheme = "rose-pine-moon", in wezterm.lua
  • try to select something in copy-mode or use your mouse

Configuration

config = {
    color_scheme = "rose-pine-moon",
}

Expected Behavior

According to rose-pine color scheme for nvim selection color must be #44415a

Logs

No response

Anything else?

No response

@mayboroda mayboroda added the bug Something isn't working label Sep 10, 2024
@mayboroda
Copy link
Author

UPD:
You can easily fix the issue with your own config for colors

config ={
...
    color_scheme = "rose-pine-moon",
    colors = {
        selection_bg = "#44415a",
    },
}

@Risinggoblin
Copy link

Risinggoblin commented Sep 14, 2024

Glad you were able to fix this. Also btw, wezterm uses rose-pine-dawn (and many other themes) directly from the iterm themes repo. So this would be an issue for that repo https://github.com/mbadolato/iTerm2-Color-Schemes (unless you have checked for this issue on iterm and this doesn't get reproduced there)

It seems like this is already an active issue on that repo: mbadolato/iTerm2-Color-Schemes#439

I think you can close the issue here. Once this gets fixed upstream on the iTerm2-Color-Schemes repo, it will most likely be patched to wezterm on the next build after that

@wez
Copy link
Owner

wez commented Sep 15, 2024

Once it is fixed upstream, it will get picked up here when I next sync the color schemes. I do that every so often in main, and always before I prepare to tag a release.

I'm going to close this because I'm not going to remember to look for this issue when I next run a sync, and I may as well close it out while I'm here.

@wez wez closed this as completed Sep 15, 2024
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants