Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] vscode syntax incorrect #144

Open
dawsbot opened this issue Feb 22, 2017 · 6 comments
Open

[bug] vscode syntax incorrect #144

dawsbot opened this issue Feb 22, 2017 · 6 comments

Comments

@dawsbot
Copy link

dawsbot commented Feb 22, 2017

The syntax highlighting in vscode is very simplistic and does not cover a large amount of the possible token colors. Specifically, there are a large amount of tokens which are colored yellow:

screen shot 2017-02-22 at 2 41 04 pm

screen shot 2017-02-22 at 2 43 16 pm

I could provide versions and example code for you to paste, but I've found this incredibly simple to reproduce. From node to shell, everything is missing it's complexity with token colorization. When comparing the same code the Sublime cobalt2 theme, they are not equal.

Other color schemes tokenize properly and work on my vscode instance, so I'm inclined to pin this issue on the vscode theme and not my local config.

@Venugopal46
Copy link

image

Same here

@dawsbot
Copy link
Author

dawsbot commented Apr 26, 2017

@Venugopal46 You'll have to quit vscode if you want cobalt2. Either that or make a massive PR to this repo. I resolved to quit vscode altogether in order to stay with the color scheme 👍

@codeofsumit
Copy link

codeofsumit commented Jul 1, 2017

same problem :-(
image

This PR looks very nice!

@fpigeonjr
Copy link

screen shot 2017-07-30 at 11 08 13 pm

Same issue on React JSX

@dawsbot
Copy link
Author

dawsbot commented Jul 31, 2017

Who would review the #151 PR? Perhaps someone like @wesbos, or do you maintain only the Sublime config?

@ghost
Copy link

ghost commented Sep 11, 2017

PR #151 is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants