Wrong color for function call

[wpbishoy]

I have an issue that happened after a couple of sublimes updates ago where the function call color (supposed to be yellow) has been lost and it turned into the same color as a variable, in PHP. This is also the case for me in JS.

See screenshot: http://i.imgur.com/uTVJkwG.png

In the screenshot current_time should be in yellow, right? Can a package conflict or something do that?

[wesbos]

Sublime updated their definitions for php and a few people have been saying it looks odd. This this most likely an issue with the php package as the theme does very little for language specific stuff

[wpbishoy]

Any suggestion we could go around this?

[wesbos]

I'm investigating here:

sublimehq/Packages#410

[FichteFoll]

You have a meta.function-call selector and support.function. I don't know which one has been used previously, but I suspect meta.function-call, which is now being overridden for PHP function valls because of the variable.function scope that they get on top of it. This more appropriate since it specifically refers to the identifier whereas meta.function-call is the scope of the entire call, including parameters and parenthesis.

Thus, the first selector should probably be replaced with variable.function. Alternatively, meta.function-call variable.function.
I can't evaluate how this would affect other syntaxes however.

[wbond]

Just a note that we are currently standardizing on meta.function-call variable.function across different languages in the default packages. So far we've done significant work on the following syntaxes:

• PHP
• Python
• JavaScript
• Go
• C/C++
• Rust
• Objective-C
• TCL

Our intent is to continue working on getting these standardized and then I'm going to write up official docs on what scopes are recommended for syntax authors and what scopes should be handled by color schemes.

My work to date has been focused on trying to preserve existing scope names where possible, but making changes where some existing languages may use one scope and others use a different scope. This, of course, will result in some things breaking along the way, but hopefully in the end we will have a much better experience for package developers and users in terms of syntaxes and color schemes.

[FichteFoll]

The forum thread https://forum.sublimetext.com/t/a-convention-for-scope-naming/17105 could also be of interest in this regard, since it also contains scope name analysis of common color schemes or syntax definitions, together with a hand ful recommendations. It does not contain all the discussion however since part of that has taken place in the sublimehq/Packages issues.

[gerardroche]

I've added a test where the function color should be #ffee80.

This test passes on st linux build 3120 with the default PHP package.

Added a fix as per @FichteFoll information.