From 43afe97078324018a625eff625bf0a596172b2bc Mon Sep 17 00:00:00 2001 From: Evgeniy Frolov Date: Thu, 12 Dec 2024 18:27:09 +0300 Subject: [PATCH 1/3] chore(ci): fix warnings Signed-off-by: Evgeniy Frolov --- .github/workflows/tests.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 63958837..1b742576 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -62,7 +62,7 @@ jobs: run: ginkgo --vet=off --race --keep-going --cover --coverpkg=./... --output-dir=$TRDL_TEST_COVERAGE_DIR ./... - name: Upload coverage artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: tests_coverage path: tests_coverage @@ -117,9 +117,9 @@ jobs: run: ginkgo -p --keep-going --cover --coverpkg=../client/...,../server/... --output-dir=$TRDL_TEST_COVERAGE_DIR ./... - name: Upload coverage artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: - name: tests_coverage + name: e2e_coverage path: tests_coverage upload_coverage: @@ -138,9 +138,8 @@ jobs: go-version-file: e2e/go.mod - name: Download coverage artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: - name: tests_coverage path: tests_coverage - name: Prepare environment From c43fc5a5b0313756a9038a79b8e7d99baf97cfe7 Mon Sep 17 00:00:00 2001 From: Evgeniy Frolov Date: Thu, 12 Dec 2024 18:29:31 +0300 Subject: [PATCH 2/3] chore(ci): fix notification Signed-off-by: Evgeniy Frolov --- .github/workflows/_notification.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/_notification.yml b/.github/workflows/_notification.yml index c43309f2..d4da2bfb 100644 --- a/.github/workflows/_notification.yml +++ b/.github/workflows/_notification.yml @@ -32,13 +32,13 @@ jobs: echo 'failed<> $GITHUB_OUTPUT echo "$(curl ${{ github.api_url }}/repos/${{ github.repository }}/actions/runs/${{ github.run_id }}/jobs | jq -r '.jobs[]| select (.conclusion == "failure") | .html_url')" >> $GITHUB_OUTPUT echo 'EOF' >> $GITHUB_OUTPUT - - if: (env.WORKFLOW_CONCLUSION == 'failure' && startsWith(github.ref, 'refs/pull/')) + - if: env.WORKFLOW_CONCLUSION == 'failure' && (startsWith(github.ref, 'refs/pull/') || github.event_name == 'workflow_dispatch') name: get user id: get_user run: | echo username=$(curl ${{ github.api_url }}/users/${{ github.triggering_actor }} | jq -r '.name' | tr '[:upper:]' '[:lower:]' | tr " " . ) >> $GITHUB_OUTPUT - - if: "(env.WORKFLOW_CONCLUSION == 'failure' && ! startsWith(github.ref, 'refs/pull/'))" + - if: "(env.WORKFLOW_CONCLUSION == 'failure' && ! startsWith(github.ref, 'refs/pull/') && github.event_name != 'workflow_dispatch' )" name: Failure notify uses: mattermost/action-mattermost-notify@master with: @@ -60,7 +60,7 @@ jobs: Workflow успешно завершился в ${{ github.repository }} :bender: [${{ github.workflow }}](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) ${{ github.ref_name }} :success: - - if: (env.WORKFLOW_CONCLUSION == 'failure' && startsWith(github.ref, 'refs/pull/')) + - if: env.WORKFLOW_CONCLUSION == 'failure' && (startsWith(github.ref, 'refs/pull/') || github.event_name == 'workflow_dispatch') name: Failure notify for PRs uses: mattermost/action-mattermost-notify@master with: From 97b9266274a4e3888f81144eabbe75d0bf27f9da Mon Sep 17 00:00:00 2001 From: Evgeniy Frolov Date: Fri, 13 Dec 2024 12:59:59 +0300 Subject: [PATCH 3/3] chore(ci): fix lint Signed-off-by: Evgeniy Frolov --- Taskfile.dist.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Taskfile.dist.yaml b/Taskfile.dist.yaml index b0490c73..0821e918 100644 --- a/Taskfile.dist.yaml +++ b/Taskfile.dist.yaml @@ -22,7 +22,7 @@ tasks: - npm install -g prettier lint: - desc: 'Run all linters in parallel.' + desc: "Run all linters in parallel." deps: - lint:prettier