Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessity of benzynes and penzynes default values #49

Open
wderekjones opened this issue Sep 13, 2019 · 0 comments
Open

Necessity of benzynes and penzynes default values #49

wderekjones opened this issue Sep 13, 2019 · 0 comments

Comments

@wderekjones
Copy link

In the code for the Vocab class, benzynes and penzynes are defined as attributes of the Vocab class outside of the init method, which I am not sure why. Furthermore however, these initialized lists are overwritten by a list comprehension that does not use any of the initial values from the lists, i.e. the initialized values are never used. I checked this behavior by instantiating a Vocab object with an empty list, as well as others using different vocabs that I have extracted. This appears to be extra code that could be removed without impacting the functionality of the network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant