Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(miniscore): _.defaults behavior for null (#41) #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(miniscore): _.defaults behavior for null (#41) #43

wants to merge 1 commit into from

Conversation

passy
Copy link
Contributor

@passy passy commented Apr 20, 2015

Adjust the _.defaults behavior to match that of underscore and lodash to
no longer treat null and undefined the same and only consider
undefined for override.

Fix #41

Review on Reviewable

@passy
fix(miniscore): _.defaults behavior for null (#41)
45c7dd0 
Adjust the _.defaults behavior to match that of underscore and lodash to
no longer treat `null` and `undefined` the same and only consider
`undefined` for override.
@nico-adstage
Copy link
Contributor

Hey @passy do you have tests planned for this? We ran into this issue recently and are curious about when this might be merged. Thanks!

@passy
Copy link
Contributor Author

passy commented Jul 7, 2015

@nico-adstage No, this is very far down on my todo list at the moment. Best chance of getting this merged is someone stepping in for the tests. I'm happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

miniscore _.defaults works bad with nulls
2 participants
@passy @nico-adstage