Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Structure the unit test badges accordining the structure of our data integrity test #425

Open
MansMeg opened this issue Nov 21, 2023 · 4 comments

Comments

@MansMeg
Copy link
Collaborator

MansMeg commented Nov 21, 2023

We should rearrange the unit test and their badges to the different unit test we do. No I think they all go in one large unit test file. Separate them out would both make it more semantically clear what we test for and at the same time enable parallelism on Github Actions.

@ninpnin
Copy link
Collaborator

ninpnin commented Dec 20, 2023

According to this answer, you need to split the workflow into multiple workflows to get multiple badges https://stackoverflow.com/a/75878936/12764816

@MansMeg
Copy link
Collaborator Author

MansMeg commented Dec 20, 2023

Yes. Thats the idea. That would also speed up the tests.

@ninpnin
Copy link
Collaborator

ninpnin commented Dec 20, 2023

  • Data tests
  • Metadata tests
  • Notebook test
  • Markdown generation test
    maybe?

@MansMeg
Copy link
Collaborator Author

MansMeg commented Dec 20, 2023

That sounds good. I would check the paper. We have a structure and substructure of the tests that we could probably use. This would communicate what is tested and that they pass.

Also maybe have more meaningful names like:
mp database tests (instead of metadata tests)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants