Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ice Ancient Sceptre not calculated #235

Open
matthewpetch opened this issue Feb 8, 2024 · 1 comment
Open

Ice Ancient Sceptre not calculated #235

matthewpetch opened this issue Feb 8, 2024 · 1 comment
Labels
bug Something isn't working triage

Comments

@matthewpetch
Copy link

matthewpetch commented Feb 8, 2024

What went wrong?

Accuracy roll is identical when using Ice Barrage regardless of whether the Ice variant of the sceptre is selected or not

example: https://dps.osrs.wiki/?id=SledSanfewSpine

What did you expect to happen?

I believe the accuracy difference should be 0.4% (could be wrong)

What browsers are you seeing the problem on?

Firefox, Chrome

What device(s) are you seeing the problem on?

Windows, Other

Any other information

No response

@matthewpetch matthewpetch added bug Something isn't working triage labels Feb 8, 2024
@SuperNerdEric
Copy link
Contributor

https://oldschool.runescape.wiki/w/Ice_ancient_sceptre

Something to be careful about when implementing this is "10% accuracy bonus given to ice spells on targets that can be frozen and are not currently frozen." which is something that I'm not really sure can 100% be accounted for in calculating DPS on a target.

  1. We need to define a list of monsters that can be frozen
  2. We need to account for the fact that the 10% bonus is only on monsters that aren't currently frozen
  3. We need to account for the fact that even with the 10% bonus you may miss your freeze and get multiple attacks with the bonus
  4. We need to account for a monster eventually becoming unfrozen

These seems like a really hard problem to properly solve without a full simulation. It might be better to just put in a warning and show the player both possible accuracy rolls / percent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants