Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC-vs-player damage #186

Open
10 of 15 tasks
leejt opened this issue Jan 29, 2024 · 3 comments
Open
10 of 15 tasks

NPC-vs-player damage #186

leejt opened this issue Jan 29, 2024 · 3 comments
Labels
epic Major, usually ongoing task feature request

Comments

@leejt
Copy link
Contributor

leejt commented Jan 29, 2024

Compute NPC-on-offense vs player-on-defense combat.

Extremely hard to do in general because we don't understand boss attack mechanics very well, but probably can get useful answers for about 80% of monsters without all that much effort

Hard parts:

  • How to make it extremely clear that it won't work very well for "complicated" monsters?
  • Which metrics (DPS, max hit, total damage taken, etc) do we display in the output section? Presumably all are fair game for graph y-axis
  • Getting protection prayers right would go a long way (but do we want these in the prayer UI?)
  • General UI bloat for defensive-minded inputs could get to be frustrating when they are irrelevant for ~95% of users

Discussed in some detail here


Implementation (PR: #201)

  • Calculate NPC's max hit (based on linear dist), attack roll, accuracy, DPS
  • Calculate player's def roll
  • Calculate damage taken per kill (Player TTK * NPC DPS)
  • Show warnings for complex monsters
  • Support defensive prayers, including 5/10/15% def prayers in the player def roll calc
  • Add defence potions to potion UI

Support common special cases

Support niche special cases

@SuperNerdEric
Copy link
Contributor

SuperNerdEric commented Feb 4, 2024

Some more special cases to consider. Some of these depend on more complex things being implemented first.

  • Staff of the dead / Toxic staff of the dead / Staff of balance / Staff of light special attack halves all of the opponent's melee damage
  • Insulated boots reduce damage from Killerwatts and Rune dragons
  • Witchwood icon- The special scream attack from cave horrors is guaranteed to deal 10% of the player's total Hitpoints in damage when the icon is not worn. The icon does not negate all damage from the scream, it instead causes the scream attack to roll as a regular attack.
  • Aberrant spectre - nose peg / slayer helm
  • Sourhogs - Reinforced goggles / slayer helm
  • Earmuffs - used to protect against banshees' screams and to reduce damage from warped terrorbirds (unclear how much?)
  • Wall beast - Spiny helmet
  • Fever spider - Slayer gloves
  • Facemask - Dust devil

@SuperNerdEric
Copy link
Contributor

On warped terrorbirds
https://twitter.com/JagexAsh/status/1754800191910072403
image

@SuperNerdEric
Copy link
Contributor

Not sure if this was well known about dragons:
https://twitter.com/JagexAsh/status/1755605769029075288
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Major, usually ongoing task feature request
Projects
None yet
Development

No branches or pull requests

2 participants