-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print module #381
base: master
Are you sure you want to change the base?
Print module #381
Conversation
Thanks for your PR @enricofer! Your branch has conflicts and it seems there are changes of your previous PRs in the change sets, which makes it hard to review. Could you please rebase your branch to the current |
jspdf is throwing many exceptions in ci-tests but I can't figure how to fix them. sorry. |
Hi @enricofer and thanks for creating this PR! I just took half an hour to have a look at the errors you encounter during tests as I was quite surprised that the dev and prod builds were working but not the test one... I unfortunately have not enough time to delve deeper into this for now but what could be done is compare the webpack configurations that are resolved in dev and test mode using, for example, In a first time, if you want to go further with your PR, you can just replace the following in the transpileDependencies: [
'jspdf'
] With this you'll be able to go on further until the reason why By the way, I can't make your PR run smoothly for now as the Thanks again for your interest in this project, All the best |
Hi, I'm submitting a new PR regarding a new print feature that allows to export the current map to pdf.
The implementation is adapted from the following Openlayers example: https://openlayers.org/en/latest/examples/print-to-scale.html
I hope you find of some interest for the project. In this case please point me out how to develop and integrate continuous testing for this module.
All the best.