-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added condition for different schedulers #691
Conversation
Great thanks for this PR. couple pieces
deepforest/data/deepforest_config.yml
|
HI @bw4sz, I have included 7 test functions in the |
Great, instead of writing 7 separate tests. Its one test with multiple parameters. Using pytest.mark.parameterize. For example: Line 159 in dba368b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Nice job @Om-Doiphode |
I have updated the
configure_optimizers
in thedeepforest/main.py
file to account for the different learning rate schedulers and also made the necessary changes in thedeepforest_config.yml
file.