-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified boxes_to_shapefile function #597
Conversation
We just need to update docs and examples to match. Quick search found |
I like this change, but note that it is backwards breaking (including for some of the lab's code). Ideally once we merge this the next release should be 2.0. A couple of possible ways to avoid needing to do this:
Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about backwards compatibility and alternative approaches before merging this.
@bw4sz - can you response to #597 (comment) when you have a minute so that we can get this one moving forward |
I don't think we are ready for this change. There is a geo-type branch that will hold points, polygons, and boxes as part of geodataframe objects. We should wait until I finish that branch this summer. |
Thanks for the contribution @Om-Doiphode - we just weren't quite ready for this one yet. Once @bw4sz lets us know this is ready to proceed we can chat about coming back to it. |
Fixes Issue #516:
The following modifications have been made:
boxes_to_shapefile
function inutilities.py
to use the 'rgb' argument instead of 'image_path'.test_utilities.py
to ensure the correct functionality of the modifiedboxes_to_shapefile
function.