Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update WebView to support gtk 4 #176

Open
sigmaSd opened this issue Oct 6, 2024 · 5 comments
Open

update WebView to support gtk 4 #176

sigmaSd opened this issue Oct 6, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@sigmaSd
Copy link
Contributor

sigmaSd commented Oct 6, 2024

The latest WebView update uses webgtkkit 6 and gtk 4 would be great if this library updates to the latest version

@eliassjogreen
Copy link
Member

Yeah, webview is in need of some major refactoring and housekeeping. Haven't had the time nor motivation to update it in the last year or so... Help is ofc always welcome :)

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Oct 8, 2024

The good thing is the new release doesn't seem to have new breaking changes.

I dlopened the new library directly, and it wroked on linux, so it seems like its just a matter of updating the buildscript. (I confirmed its using gtk 4 using GTK_DEBUG=all)

I'm not familiar with cross building for mac and windows, so I can't help in this area for now.

@SteffenL
Copy link

SteffenL commented Oct 9, 2024

I haven't been involved in this project but I'll just say that the core webview library can currently be compiled to support one of the following, but not all at the same time:

  • GTK 4, WebKitGTK API 6.0
  • GTK 3, WebKitGTK API 4.1
  • GTK 3, WebKitGTK API 4.0

Note that some features aren't available anymore in GTK 4 and have no replacements.

@eliassjogreen
Copy link
Member

Looking at this now quickly I think the biggest problem is that we are using a 2 year old version of webview. We need to update the build scripts to support the latest webview and then we should be able to build for each variant. We should then probably build all of the different variants in matrix CI action, that way we can support each variant :)

@eliassjogreen eliassjogreen added the enhancement New feature or request label Oct 15, 2024
@congzhangzh
Copy link
Contributor

related: #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants