Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: New workflow won't save due to regression with profileid field #1945

Closed
tw4l opened this issue Jul 18, 2024 · 0 comments · Fixed by #1946
Closed

[Bug]: New workflow won't save due to regression with profileid field #1945

tw4l opened this issue Jul 18, 2024 · 0 comments · Fixed by #1946
Assignees
Labels
bug Something isn't working

Comments

@tw4l
Copy link
Member

tw4l commented Jul 18, 2024

Browsertrix Version

v1.11.0-beta.1-f7a675ea

What did you expect to happen? What happened instead?

I expect that a new workflow with the default browser profile will save and start a crawl.

Instead I get the following error: profileid value is not a valid uuid

Reproduction instructions

  1. Try to create a workflow with the default profile
  2. Watch it fail

Screenshots / Video

No response

Environment

No response

Additional details

It looks like this is a regression from #1935 - profileid in CrawlConfigIn was previously type Union[UUID, EmptyStr, None] and would set an empty string to None in the ops method before creating the workflow in the database. Now that it's just Optional[UUID], the frontend passing an empty string instead causes the workflow not to save.

The changes in #1935 make sense for the backend, we should make sure the frontend passes None rather than an empty string if no browser profile is set.

@tw4l tw4l added the bug Something isn't working label Jul 18, 2024
@tw4l tw4l self-assigned this Jul 18, 2024
@tw4l tw4l moved this from Triage to Ready in Webrecorder Projects Jul 18, 2024
@tw4l tw4l moved this from Ready to Implementing in Webrecorder Projects Jul 18, 2024
@ikreymer ikreymer moved this from Implementing to Todo in Webrecorder Projects Jul 18, 2024
@tw4l tw4l moved this from Todo to Implementing in Webrecorder Projects Jul 18, 2024
@tw4l tw4l moved this from Implementing to In Review in Webrecorder Projects Jul 18, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

1 participant