Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Public org collections page #1051

Open
7 tasks
tw4l opened this issue Aug 4, 2023 · 5 comments
Open
7 tasks

[Feature]: Public org collections page #1051

tw4l opened this issue Aug 4, 2023 · 5 comments
Assignees
Labels
back end Requires back end dev work feature design This issue tracks smaller sub issues that compose a feature front end Requires front end dev work

Comments

@tw4l
Copy link
Member

tw4l commented Aug 4, 2023

Context

Now that we have public collections, users may want to direct people to a listing of the public collections that are available to view. This could include the name, description, and a link to each, and would help discoverability of the collections that have been made public, which are otherwise only discoverable if you already have the URL.

Requirements

  • Anyone can view a list public collections in an org
    • List page (publicly accessible with a link) of collections with thumbnail images that an org has made public
    • Org page is only public if explicitly enabled in the org settings or on signup
    • Clicking on each thumbnail directs users into a full page ReplayWebpage viewer for that collection where they can then view highlighted pages
  • Collections can be made public if the org has chosen to be listed as public
    • If an org has chosen to hide themselves from public view, collections can only be private or unlisted
  • Anyone can view an individual public collection
  • Public collections can be downloaded

Tasks

@tw4l tw4l assigned tw4l and unassigned tw4l Aug 4, 2023
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Aug 4, 2023
@tw4l tw4l added the feature design This issue tracks smaller sub issues that compose a feature label Aug 4, 2023
@SuaYoo SuaYoo moved this from Todo to In Design in Webrecorder Projects Nov 4, 2024
@SuaYoo SuaYoo changed the title Implement public page listing public collections [Feature]: Public collection improvements Nov 4, 2024
@SuaYoo SuaYoo added the front end Requires front end dev work label Nov 4, 2024
@SuaYoo SuaYoo added the back end Requires back end dev work label Nov 18, 2024
@Shrinks99 Shrinks99 added this to the Public Collections milestone Nov 18, 2024
@SuaYoo
Copy link
Member

SuaYoo commented Nov 21, 2024

@tw4l We'll also need an endpoint for retrieving public collections for an org by slug without revealing the existence of the org. The response will need to include the list of public collections and the org name. Updated the task list!

@SuaYoo SuaYoo changed the title [Feature]: Public collection improvements [Feature]: Public org collections page Nov 25, 2024
@SuaYoo
Copy link
Member

SuaYoo commented Nov 25, 2024

@Shrinks99 @ikreymer do we want to support a public org description field in this iteration?

@Shrinks99
Copy link
Member

I would like to, ideally a character limited one.

@SuaYoo
Copy link
Member

SuaYoo commented Nov 25, 2024

do we want to support a public org description field in this iteration?

I would like to, ideally a character limited one.

@tw4l is this a quick change to tack on to #2174?

@tw4l
Copy link
Member Author

tw4l commented Nov 26, 2024

@tw4l is this a quick change to tack on to #2174?

Added!

tw4l added a commit that referenced this issue Nov 27, 2024
Fixes #1051 

If org with provided slug doesn't exist or no public collections exist
for that org, return same 404 response with a detail of
"public_profile_not_found" to prevent people from using public endpoint
to determine whether an org exists.

Endpoint is `GET /api/public-collections/<org-slug>` (no auth needed) to
avoid collisions with existing org and collection endpoints.
SuaYoo pushed a commit that referenced this issue Nov 27, 2024
Fixes #1051 

If org with provided slug doesn't exist or no public collections exist
for that org, return same 404 response with a detail of
"public_profile_not_found" to prevent people from using public endpoint
to determine whether an org exists.

Endpoint is `GET /api/public-collections/<org-slug>` (no auth needed) to
avoid collisions with existing org and collection endpoints.
tw4l added a commit that referenced this issue Nov 27, 2024
Fixes #1051 

If org with provided slug doesn't exist or no public collections exist
for that org, return same 404 response with a detail of
"public_profile_not_found" to prevent people from using public endpoint
to determine whether an org exists.

Endpoint is `GET /api/public-collections/<org-slug>` (no auth needed) to
avoid collisions with existing org and collection endpoints.
SuaYoo pushed a commit that referenced this issue Nov 28, 2024
Fixes #1051 

If org with provided slug doesn't exist or no public collections exist
for that org, return same 404 response with a detail of
"public_profile_not_found" to prevent people from using public endpoint
to determine whether an org exists.

Endpoint is `GET /api/public-collections/<org-slug>` (no auth needed) to
avoid collisions with existing org and collection endpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end Requires back end dev work feature design This issue tracks smaller sub issues that compose a feature front end Requires front end dev work
Projects
Status: In Design
Development

No branches or pull requests

3 participants