New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizing Batch #5b tests #3690

Closed

Asmaloth wants to merge 43 commits into webiny:next from Asmaloth:batch-5b

Contributor

Asmaloth commented Nov 10, 2023 •

edited

Loading

Related Issue

No Jira ticket currently exists but for more documentation visit: https://www.notion.so/webiny/Webiny-Testing-43be8707c3df48cbbf87d06a57720faa

Your solution

Using a combination of UI tests and graphQL commands we have been able to achieve the wanted results.

How has this been tested?

Using eslint and CI checks.

Screenshots (if relevant):

N/A

Asmaloth and others added 14 commits

October 29, 2023 15:54


          Adding batches 3 and 4

0b621cb


          Revert "Adding batches 3 and 4"

5b8a742

This reverts commit 0b621cb.


          Revert "Revert "Adding batches 3 and 4""

436ceac

This reverts commit 5b8a742.


          Revert "Revert "Revert "Adding batches 3 and 4"""

e65d312

This reverts commit 436ceac.


          Merge branch 'next' of https://github.com/Asmaloth/webiny-js into next

8ad66df


          Adding 3/4 tests for batch #5b

769d08d


          Adding last batch 4 test

b310e89


          Trying to implement cy.origin with custom commands(broken)

fd78bbe


          Final batch 5b commit

912067b


          Ran prettier:fix

d3abed4


          chore(eslint): fix remaining linting warnings

3b230da


          chore(eslint): fix remaining linting warnings

e71a3a2


          chore(tests): fixing commands.js imports

abd60a0


          Merge branch 'next' into batch-5b

65178b0

adrians5j requested changes

View reviewed changes

Member

adrians5j left a comment

Did another iteration, but I sense there will be more to double check, especially around types.

cypress-tests/cypress/e2e/admin/pageBuilder/menus/menuCrud.cy.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/e2e/admin/pageBuilder/menus/menuCrud.cy.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/reloadUntil.ts Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbUpdatePage.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbUpdatePage.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbPublishPage.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbListPages.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbDeletePage.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbDeleteAllMenus.ts Outdated Show resolved Hide resolved

Asmaloth and others added 3 commits

November 23, 2023 14:05


          fix(pr): resolving all comments from PR

0709ffa


          fix(pr): resolving all comments from PR

9846e25


          chore: add yarn cy:ts script

514a470

adrians5j requested changes

View reviewed changes

Member

adrians5j left a comment

Mostly, some code-level things to take a look at. Let's get this in order first, just so we don't end up with a pile of bad code in the near future. :)

cypress-tests/cypress/support/pageBuilder/pbUpdatePage.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbUpdatePage.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbPublishPage.ts Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbPublishPage.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/pbListPages.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/support/pageBuilder/reloadUntil.ts Show resolved Hide resolved

cypress-tests/cypress/e2e/admin/pageBuilder/menus/menuCrud.cy.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/e2e/admin/pageBuilder/menus/menuCrud.cy.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/e2e/admin/pageBuilder/menus/menuCrud.cy.ts Outdated Show resolved Hide resolved

cypress-tests/cypress/e2e/admin/pageBuilder/menus/menuCrud.cy.ts Outdated Show resolved Hide resolved


          fix(pr): fixing most of the latest pr comments

82b9de5

Asmaloth force-pushed the batch-5b branch from 514a470 to 82b9de5 Compare

November 28, 2023 13:48


          Merge branch 'next' into batch-5b

7f2fbc6

Member

adrians5j commented Nov 30, 2023

/cypress

github-actions bot commented Nov 30, 2023

Cypress E2E tests have been initiated (for more information, click here). ✨

Member

adrians5j commented Nov 30, 2023

/cypress

github-actions bot commented Nov 30, 2023

Cypress E2E tests have been initiated (for more information, click here). ✨

Member

adrians5j commented Nov 30, 2023

/cypress

github-actions bot commented Nov 30, 2023

Cypress E2E tests have been initiated (for more information, click here). ✨


          fix(pr): fixing the latest pr comments

57e375a

Member

adrians5j commented Dec 4, 2023

/cypress

Asmaloth and others added 2 commits

December 7, 2023 17:19


          fix(pr): adding some minor polishes

2efd93d


          Merge branch 'next' into batch-5b

7bb83b7

Member

adrians5j commented Dec 8, 2023

/cypress

github-actions bot commented Dec 8, 2023

Cypress E2E tests have been initiated (for more information, click here). ✨


          Merge branch 'next' into batch-5b

7263e40

Member

adrians5j commented Dec 11, 2023

/cypress

github-actions bot commented Dec 11, 2023

Cypress E2E tests have been initiated (for more information, click here). ✨

Member

adrians5j commented Dec 12, 2023

/cypress

github-actions bot commented Dec 12, 2023

Cypress E2E tests have been initiated (for more information, click here). ✨

adrians5j and others added 5 commits

December 12, 2023 16:32


          wip: improve menu-items test

eab22de


          Merge branch 'next' into batch-5b

3440e4b


          wip: refactor utils

6ea6309


          wip: refactor utils

b3db404


          wip: refactor utils

288435c

Member

adrians5j commented Jan 4, 2024

/cypress

github-actions bot commented Jan 4, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

adrians5j added 3 commits

January 4, 2024 14:39


          wip: refactor utils

37b5cc5


          wip: refactor utils

06a393a


          wip: refactor utils

b793d0d

Member

adrians5j commented Jan 4, 2024

/cypress

github-actions bot commented Jan 4, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨


          wip: refactor utils

fd1d729

Member

adrians5j commented Jan 4, 2024

/cypress

github-actions bot commented Jan 4, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨


          wip: refactor utils

b99ab37

Member

adrians5j commented Jan 5, 2024

/cypress

github-actions bot commented Jan 5, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

adrians5j mentioned this pull request

Cypress Tests - Batch 5b #3798

Merged

Member

adrians5j commented Jan 6, 2024

No longer needed, merged in a separate PR.

adrians5j closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet