Rename WGPUPopErrorScopeStatus_EmptyStack -> Error, change message rules #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
commented
Nov 23, 2024
| @@ -637,7 +637,7 @@ typedef enum WGPUPopErrorScopeStatus { | |||
| * `0x00000003`. | |||
| * The error scope stack could not be popped, because it was empty. | |||
| */ | |||
| WGPUPopErrorScopeStatus_EmptyStack = 0x00000003, | |||
| WGPUPopErrorScopeStatus_Error = 0x00000003, | |||
There was a problem hiding this comment.
I called this Error instead of ValidationError because I thought WGPUPopErrorScopeStatus_ValidationError vs WGPUErrorType_Validation would be really confusing.
Hopefully just Error is not too bad.
lokokung
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369
(dawn bug https://crbug.com/378453261)