-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nullable annotations would be useful #119
Comments
Bump. It's unclear if a create method fails due to a validation failure, if it should return |
See #157 for arguments to the API. In general return values that are object are never null, and instead are invalid objects, like the JS API. |
I was thinking of |
Erhm, that's non-standard and just an LLVM thing. That header also needs to be compatible with other C compilers like GCC or MSVC. At best we could do a |
for future reference: |
|
- Also adds WGPU_NULLABLE instead of the /* nullable */ comments - Also adds WGPUFeatureName_Float32Filterable - Also adds struct forward declarations and move funtion pointers typedefs before the struct definitions, so that struct can contain function pointers. Fixes webgpu-native#179 Fixes webgpu-native#119
- Also adds WGPU_NULLABLE instead of the /* nullable */ comments - Also adds WGPUFeatureName_Float32Filterable - Also adds struct forward declarations and move funtion pointers typedefs before the struct definitions, so that struct can contain function pointers. Fixes webgpu-native#179 Fixes webgpu-native#119
Partially addressed in #182, but there were some open follow-up questions: |
Added the important item from there to #190. Closing this issue, so we can track there. |
It would help implementations know what's allowed to be null and what isn't.
https://clang.llvm.org/docs/analyzer/developer-docs/nullability.html
The text was updated successfully, but these errors were encountered: