Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the usage of <html> tag from the docs and samples #177

Closed
hyyan opened this issue Jun 28, 2024 · 2 comments
Closed

Remove the usage of <html> tag from the docs and samples #177

hyyan opened this issue Jun 28, 2024 · 2 comments
Assignees
@bbrennanbasis
Labels
Priority: Medium

Comments

@hyyan
Copy link
Member

hyyan commented Jun 28, 2024 •
edited
Loading

webforj/webforj#638

Remove the usage of the <html> tag from the documentation and samples, and switch to using the setHtml method. Don't Mention the <html> tag.

For instance :
https://documentation.webforj.com/docs/components/button#adding-icons-to-buttons
@bbrennanbasis bbrennanbasis mentioned this issue Sep 10, 2024
Closed
@bbrennanbasis
Copy link
Contributor

The usage of the <html> tag in the docs was only in reference to adding an icon. The following PRs combined will resolve this issue for the docs:

The usage of the <html> tag in the samples will be addressed in the webforj-docs-samples PR #89.

@bbrennanbasis bbrennanbasis mentioned this issue Oct 21, 2024
Merged
@bbrennanbasis
Copy link
Contributor

The usage of the <html> tag in the docs was only in reference to adding an icon. The following PRs combined will resolve this issue for the docs:

The usage of the <html> tag in the samples will be addressed in the webforj-docs-samples PR #89.

All the PRs mentioned in this previous comment have been merged, so this issue is now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbrennanbasis bbrennanbasis

Labels
Priority: Medium
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

177-remove-html-tag webforj/webforj-docs
4 participants
@hyyan @MatthewHawkins @gosteenBASIS @bbrennanbasis