beforeChange fires for disabled switches

[Tazaf]

Hi!

First, thanks for this component! It's both complete and flexible 👍

I've stumble upon a behavior that, I think, should not happen. As this issue's title says, the beforeChange observable is subscribed even when the switch is in a disabled state.

That doesn't seem to make much sense, as a disabled switch should be... well... disabled and thus should not trigger any event.

I think this issue is caused by the lack of disabled check in this line:

ngx-ui-switch/src/lib/ui-switch/ui-switch.component.ts

Line 157 in 4995c55

if (this.beforeChange) {

which probably should be:

  onToggle(event: MouseEvent) {
    if (this.beforeChange && !this.disabled) {
      // ...
    } else {
      this.onClick(event);
    }
  }

I've seen that the onClick method does check for the disabled state, but in my case, it's too late since I'm doing some backend operation in the beforeChange observable ; my http call is made whatever my switch's disabled status is.

(Might be related to #375 and/or #353)

[cmckni3]

Yeah I don't think it was implemented correctly and I didn't test it (I don't use that functionality). I handle it in my application.

PRs welcome.

[cmckni3]

Check out 10.0.2