From 969b55fc72cb2cfdd0fa431d8cf6d6348f0904e1 Mon Sep 17 00:00:00 2001
From: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
Date: Thu, 12 Oct 2023 11:22:55 -0400
Subject: [PATCH] add documentation

---
 .../web3_plugin_guide/plugin_authors.md       | 25 +++++++++++++++++++
 .../src/tx/transactionFactory.ts              |  4 +--
 .../integration/web3-plugin-eip-4844.test.ts  |  6 +----
 3 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/docs/docs/guides/web3_plugin_guide/plugin_authors.md b/docs/docs/guides/web3_plugin_guide/plugin_authors.md
index f7f057edd07..31f26d6ce3f 100644
--- a/docs/docs/guides/web3_plugin_guide/plugin_authors.md
+++ b/docs/docs/guides/web3_plugin_guide/plugin_authors.md
@@ -34,6 +34,31 @@ It is important to note that the plugin name should be structured as `@<organiza
 
 When your users install your plugin, this will allow the package manager to make use of the user installed `web3` if available and if the version satisfies the version constraints instead of installing it's own version of `web3`.
 
+## Add New Transaction Type
+
+Furthermore, you have the flexibility to expand your range of transaction types, enhancing compatibility with the `web3.js` library.
+
+
+```typescript
+// create new TransactionType class which extends BaseTransaction class
+import { BaseTransaction } from 'web3-eth-accounts';
+const TRANSACTION_TYPE = 15;
+class SomeNewTxTypeTransaction extends BaseTransaction {
+    // ...
+}
+
+// create new plugin and add `SomeNewTxTypeTransaction` to the library
+import { Web3EthPluginBase } from 'web3';
+
+class SomeNewTxTypeTransactionPlugin extends Web3PluginBase {
+   public pluginNamespace = 'someNewTxTypeTransaction';
+   public constructor() {
+      super();
+      TransactionFactory.registerTransactionType(TRANSACTION_TYPE, SomeNewTxTypeTransaction);
+   }
+}
+```
+
 ## Extending `Web3PluginBase`
 
 Your plugin class should `extend` the `Web3PluginBase` abstract class. This class `extends` [Web3Context](/api/web3-core/class/Web3Context) and when the user registers your plugin with a class, your plugin's `Web3Context` will point to the module's `Web3Context` giving your plugin access to things such as user configured [requestManager](/api/web3-core/class/Web3Context#requestManager) and [accountProvider](/api/web3-core/class/Web3Context#accountProvider).
diff --git a/packages/web3-eth-accounts/src/tx/transactionFactory.ts b/packages/web3-eth-accounts/src/tx/transactionFactory.ts
index aacdbdd1757..718d7152850 100644
--- a/packages/web3-eth-accounts/src/tx/transactionFactory.ts
+++ b/packages/web3-eth-accounts/src/tx/transactionFactory.ts
@@ -29,7 +29,7 @@ import type {
 } from './types.js';
 import { BaseTransaction } from './baseTransaction.js';
 
-const extraTxTypes: Map<Numbers, typeof BaseTransaction> = new Map();
+const extraTxTypes: Map<Numbers, typeof BaseTransaction<unknown>> = new Map();
 
 // eslint-disable-next-line @typescript-eslint/no-extraneous-class
 export class TransactionFactory {
@@ -41,7 +41,7 @@ export class TransactionFactory {
 		return Number(uint8ArrayToBigInt(toUint8Array(txType)));
 	}
 
-	public static registerTransactionType<NewTxTypeClass extends typeof BaseTransaction>(
+	public static registerTransactionType<NewTxTypeClass extends typeof BaseTransaction<unknown>>(
 		type: Numbers,
 		txClass: NewTxTypeClass,
 	) {
diff --git a/packages/web3/test/integration/web3-plugin-eip-4844.test.ts b/packages/web3/test/integration/web3-plugin-eip-4844.test.ts
index af55577f8c7..02df781436c 100644
--- a/packages/web3/test/integration/web3-plugin-eip-4844.test.ts
+++ b/packages/web3/test/integration/web3-plugin-eip-4844.test.ts
@@ -31,11 +31,7 @@ class Eip4844Plugin extends Web3PluginBase {
 	public pluginNamespace = 'txType3';
 	public constructor() {
 		super();
-		TransactionFactory.registerTransactionType(
-			TRANSACTION_TYPE,
-			// @ts-expect-error fix type
-			SomeNewTxTypeTransaction,
-		);
+		TransactionFactory.registerTransactionType(TRANSACTION_TYPE, SomeNewTxTypeTransaction);
 	}
 }