Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should test_driver.click() specify "mouse" click? #48158

Closed
mustaqahmed opened this issue Sep 13, 2024 · 1 comment
Closed

Should test_driver.click() specify "mouse" click? #48158

mustaqahmed opened this issue Sep 13, 2024 · 1 comment

Comments

@mustaqahmed
Copy link
Member

The documentation for test_driver.click() does not specify if the click is with mouse or not.

This seem important because clicking with "touch", for example, could have a slightly different expectation (e.g. implicit pointer capture, see web-platform-tests/interop#695). Also note that a click can come from a keyboard too.

I just confirmed that both ChromeDriver and GeckoDriver use "mouse".

FYI @masayuki-nakano
@mustaqahmed
Copy link
Member Author

mustaqahmed commented Sep 13, 2024 •
edited
Loading

"Forwarding" a comment by @gsnedders from the interop thread:

It should match the semantics of https://w3c.github.io/webdriver/#element-click, which I think ends up with https://w3c.github.io/webdriver/#dfn-default-pointer-parameters (i.e., mouse), though @jgraham might remember these parts of the spec better than me.

@mustaqahmed mustaqahmed mentioned this issue Sep 13, 2024
Closed
chromium-wpt-export-bot pushed a commit that referenced this issue Sep 20, 2024
@mustaqahmed @chromium-wpt-export-bot
Update test_driver.click() documentation to specify "mouse" click.
f04858e 
#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Merged
aarongable pushed a commit to chromium/chromium that referenced this issue Sep 20, 2024
@mustaqahmed
Update test_driver.click() documentation to specify "mouse" click.
c341ddf 
web-platform-tests/wpt#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <[email protected]>
Auto-Submit: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1358149}
chromium-wpt-export-bot pushed a commit that referenced this issue Sep 20, 2024
@mustaqahmed @chromium-wpt-export-bot
Update test_driver.click() documentation to specify "mouse" click.
d266c86 
#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <[email protected]>
Auto-Submit: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1358149}
chromium-wpt-export-bot pushed a commit that referenced this issue Sep 20, 2024
@mustaqahmed @chromium-wpt-export-bot
Update test_driver.click() documentation to specify "mouse" click.
783e382 
#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <[email protected]>
Auto-Submit: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1358149}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 25, 2024
@mustaqahmed @moz-wptsync-bot
Bug 1920159 [wpt PR 48288] - Update test_driver.click() documentation…
4d5ed8e 
… to specify "mouse" click., a=testonly

Automatic update from web-platform-tests
Update test_driver.click() documentation to specify "mouse" click.

web-platform-tests/wpt#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <[email protected]>
Auto-Submit: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1358149}

--

wpt-commits: 783e382187aad9beff086df99e0e758246c5aacf
wpt-pr: 48288
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 26, 2024
@marco-c
Bug 1920159 [wpt PR 48288] - Update test_driver.click() documentation…
986a9e0 
… to specify "mouse" click., a=testonly

Automatic update from web-platform-tests
Update test_driver.click() documentation to specify "mouse" click.

web-platform-tests/wpt#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <flackrchromium.org>
Auto-Submit: Mustaq Ahmed <mustaqchromium.org>
Reviewed-by: Robert Flack <flackrchromium.org>
Cr-Commit-Position: refs/heads/main{#1358149}

--

wpt-commits: 783e382187aad9beff086df99e0e758246c5aacf
wpt-pr: 48288

UltraBlame original commit: 6e281d0d9f196c72d8d08b2c84e95f3fa8eaf54f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 26, 2024
@marco-c
Bug 1920159 [wpt PR 48288] - Update test_driver.click() documentation…
734e80f 
… to specify "mouse" click., a=testonly

Automatic update from web-platform-tests
Update test_driver.click() documentation to specify "mouse" click.

web-platform-tests/wpt#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <flackrchromium.org>
Auto-Submit: Mustaq Ahmed <mustaqchromium.org>
Reviewed-by: Robert Flack <flackrchromium.org>
Cr-Commit-Position: refs/heads/main{#1358149}

--

wpt-commits: 783e382187aad9beff086df99e0e758246c5aacf
wpt-pr: 48288

UltraBlame original commit: 6e281d0d9f196c72d8d08b2c84e95f3fa8eaf54f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 26, 2024
@marco-c
Bug 1920159 [wpt PR 48288] - Update test_driver.click() documentation…
521b9e8 
… to specify "mouse" click., a=testonly

Automatic update from web-platform-tests
Update test_driver.click() documentation to specify "mouse" click.

web-platform-tests/wpt#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <flackrchromium.org>
Auto-Submit: Mustaq Ahmed <mustaqchromium.org>
Reviewed-by: Robert Flack <flackrchromium.org>
Cr-Commit-Position: refs/heads/main{#1358149}

--

wpt-commits: 783e382187aad9beff086df99e0e758246c5aacf
wpt-pr: 48288

UltraBlame original commit: 6e281d0d9f196c72d8d08b2c84e95f3fa8eaf54f
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Sep 26, 2024
@mustaqahmed @moz-wptsync-bot
Bug 1920159 [wpt PR 48288] - Update test_driver.click() documentation…
a339cfe 
… to specify "mouse" click., a=testonly

Automatic update from web-platform-tests
Update test_driver.click() documentation to specify "mouse" click.

web-platform-tests/wpt#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <[email protected]>
Auto-Submit: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1358149}

--

wpt-commits: 783e382187aad9beff086df99e0e758246c5aacf
wpt-pr: 48288
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Sep 27, 2024
@mustaqahmed @moz-wptsync-bot
Bug 1920159 [wpt PR 48288] - Update test_driver.click() documentation…
3c1703c 
… to specify "mouse" click., a=testonly

Automatic update from web-platform-tests
Update test_driver.click() documentation to specify "mouse" click.

web-platform-tests/wpt#48158

Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351
Commit-Queue: Robert Flack <[email protected]>
Auto-Submit: Mustaq Ahmed <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1358149}

--

wpt-commits: 783e382187aad9beff086df99e0e758246c5aacf
wpt-pr: 48288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mustaqahmed