Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer restarts can be squelched #13

Open
peterbourgon opened this issue Feb 19, 2016 · 0 comments
Open

Peer restarts can be squelched #13

peterbourgon opened this issue Feb 19, 2016 · 0 comments

Comments

@peterbourgon
Copy link
Contributor

This is a transplant of weaveworks/weave#1867. Quote,

When a peer restarts quickly, not all other peers necessarily see the peer go away, since topology gossip data merging may combine the removal and addition, or the events get re-ordered in transit, with the removal being skipped (since it will have an earlier version) - both of these effectively just end up updating the peer UID and version. If that happens on just a single peer then the DNS entries of the restarted peer are all retained. This is problematic in two ways:

  • if any containers died on the peer while the weave router was down, their entries are leaked.
  • for surviving containers, the version of the re-created entry may well be lower than the existing one, e.g. if previously the entry had been tombstoned and resurrected a few times. If the last version of the entry known by surviving peers was a tombstone, then this will effectively wipe out the re-created entry.

Possible fix,

Peers could invoke the OnGC callbacks when the UID of a peer changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant