Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant broadcast topology update in case of fully-connected mesh of node #104

Open
murali-reddy opened this issue Mar 2, 2019 · 1 comment

Comments

@murali-reddy
Copy link
Contributor

When local peer connects/disconnects to remote peers (handleAddConnection,handleConnectionEstablished,handleDeleteConnection) there is broadcastTopologyUpdate

In case of fully connected mesh nodes like in case of Kubernetes deployed on AWS with Weave-net, broadcast topology updates are redundant as each node could be connected to added/deleted node so it can learn the topology first-hand.

It would be desirable to minimize the broadcast topology updates at least in case of fully connected mesh nodes.

@bboreham
Copy link
Contributor

bboreham commented Mar 2, 2019

Good point.

I agree it is redundant; however I can't see an easy way for one node to know it is redundant.
Something like: "all the nodes I am about to broadcast to are already connected to X, so they don't care that I just connected to X" ? But that only reduces half of the noise, I think.

We have discussed IRL a "mode switch" where we tell Mesh we expect a fully-connected topology, and in that mode topology broadcasts can be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants