New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change type and interface #52

Merged

wcho21 merged 2 commits into dev from feat

Jan 31, 2024

Owner

wcho21 commented Jan 31, 2024 •

edited

Loading

refactor

use type consistently
change interface to extend fields, not including the fields as a field (e.g., see syntax node types)

note:

typescript: for an interface T, and another interface U that extends T, the the type of fields that belongs only to U can be obtained by Omit<U, keyof T>, which is heavily used for refactoring types.


          change interfaces to extend fields

807e373

wcho21 self-assigned this


          fix type import

ffef180

wcho21 merged commit 3283c78 into dev

1 check passed

wcho21 deleted the feat branch

January 31, 2024 08:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet