-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing utils module #151
base: master
Are you sure you want to change the base?
Conversation
DrPyser
commented
Sep 20, 2024
- JSON typing alias
Build succeeded. ✔️ tox-linters SUCCESS in 4m 13s |
bc7c408
to
b7fee37
Compare
Build failed. ✔️ tox-linters SUCCESS in 4m 42s |
8c89d60
to
159f4dd
Compare
Build succeeded. ✔️ tox-linters SUCCESS in 6m 24s |
@@ -0,0 +1,24 @@ | |||
# Copyright 2014-2024 The Wazo Authors (see the AUTHORS file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 2014?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I think I copied it from somewhere? I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added mergeit
label in the release process
But I don't approve this PR
The usage (for now) is only in python client which should never depend of this library (even only for typing)
We already discussed this previously, sorry that wasn't understood then. Why is it bad for the clients to depend on xivo-lib-python? I suppose we should duplicate this module in wazo-lib-rest-client for usage in wazo python clients? |
xivo-lib-python is intended to be a server library, not to be installed outside of the server. We don't want to block ourself/packaging because we add a dependency on wazo python clients (ex: build debian based on requirements.txt, or move requirements.txt to setup.py/pyproject.toml) Rule of thumb about lib-python, when it doesn't make sense or if the code is huge, make a separate module. IMHO we are in the first scenario
Yes it's the easier solution (and probably the one that is worth it) |