Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wazo 3564 improve channel regex #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Wazo 3564 improve channel regex #127

wants to merge 2 commits into from

Conversation

DrPyser
Copy link
Contributor

@DrPyser DrPyser commented Dec 19, 2023 •
edited
Loading

This partially addresses https://wazo-dev.atlassian.net/browse/WAZO-3539 as well by adding | to the regex, though does not address arbitrary valid characters(other similar issues might pop up).

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/3a230966ceb4442da22ee6e91ad520ea

✔️ tox-linters SUCCESS in 5m 58s
✔️ wazo-tox-py39 SUCCESS in 6m 03s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 29s
✔️ debian-packaging-bullseye SUCCESS in 1m 47s

@DrPyser
Added '+' and '|' characters in channel regex
ee5462a 
why: support valid asterisk channels using valid extension syntax
@DrPyser DrPyser force-pushed the WAZO-3564-improve-channel-regex branch from 45da371 to ee5462a Compare December 19, 2023 21:18
@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build succeeded.
https://zuul.wazo.community/zuul/t/local/buildset/11d0d384e81e41cd8eefe1f23d050079

✔️ tox-linters SUCCESS in 4m 07s
✔️ wazo-tox-py39 SUCCESS in 5m 58s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 07s
✔️ debian-packaging-bullseye SUCCESS in 1m 57s

@wazo-community-zuul Wazo community Zuul
Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/09fcca7eabe449ff9604a115f2151a66

❌ tox-linters FAILURE in 5m 27s
✔️ wazo-tox-py39 SUCCESS in 4m 11s
✔️ wazo-tox-integration-py39 SUCCESS in 3m 38s
✔️ debian-packaging-bullseye SUCCESS in 1m 47s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DrPyser