Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwcomposer: Synchronization fixes #48

Draft
wants to merge 3 commits into
base: lineage-18.1
Choose a base branch
from

Conversation

aleasto
Copy link
Member

@aleasto aleasto commented Jan 29, 2023

No description provided.

@aleasto
Copy link
Member Author

aleasto commented Jan 29, 2023

@dos1

This almost works. But sometimes it breaks when switching from full-ui mode to single-app mode

@aleasto
Copy link
Member Author

aleasto commented Jan 29, 2023

Well, that is caused by contents->retireFenceFd, not the layers one.

hwcomposer/hwcomposer.cpp Outdated Show resolved Hide resolved
@aleasto
Copy link
Member Author

aleasto commented Feb 1, 2023

So, I believe this logic is correct.

However it relies on the assumption that the compositor will always reliably send a wl_buffer::release event, even when replacing a surface's buffer with itself again. Mutter curiously seems to respect this, but i think it is not the ideal behaviour; indeed kwin and weston do it differently.

So I believe I'm just going to keep this here to be revisited, and for now disable the per-layer synchronization.

@aleasto aleasto marked this pull request as draft February 1, 2023 00:15
@aleasto
Copy link
Member Author

aleasto commented Feb 1, 2023

Alternatively, since the buffer cache is very rarely used as most frames post-boot have the GEOMETRY_CHANGED flag, we could just remove it and then wl_buffer::release should behave how this logic requires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant