Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to delete selected memories #7

Open
wawawario2 opened this issue Apr 3, 2023 · 6 comments
Open

Allow users to delete selected memories #7

wawawario2 opened this issue Apr 3, 2023 · 6 comments
Assignees

Comments

@wawawario2
Copy link
Owner

This is a fairly common request. It'd be useful when "filler/junk" memories are loaded into the context to allow users to delete them.

@wawawario2 wawawario2 self-assigned this Apr 3, 2023
@USBhost
Copy link

USBhost commented Apr 3, 2023

I wonder if you can hijack the prompt to a special command to tell it not to remember something.

@wawawario2
Copy link
Owner Author

I wonder if you can hijack the prompt to a special command to tell it not to remember something.

I think a general purpose "there may be filler memories, just ignore them" can help here, especially for more powerful LLMs. That said, that would be mostly as a form of a "backup" as we need to protect our limited context as much as we can.

@wawawario2
Copy link
Owner Author

This would be easiest if we ported the backend to something like chromadb since its API naturally supports deletion of arbitrary memories. As for exposing that option to the end user, that's a bit trickier. If we had just one memory in the memory context, it's easy as we can simply have a button that says "Delete current memory". With an arbitrary number of memories, we'd need a user-friendly way of saying "Delete the nth memory" or "Delete the least relevant memory".

@Interpause
Copy link

To expand on this, would it be plausible to have a fully-featured memory editor? So able to search, edit, remove & add memories. I think if its awkward to integrate into the webUI, it could be done as a separate app?

@luthis1124
Copy link

I have been thinking about this, I have been using a sqlite editor but it would be better to have this ability just in the gui.
I'm still learning gradio, so I'm not sure if this would need to be a separate extension, but it definitely needs to have it's own collapsible section.

It would work best with a filter box on top, and then the list of memories below, where you can highlight by clicking, and then a 'delete' button with confirmation.

Then just reindex the memories. I notice that the first column is just int ID, not an identity column, is there a reason for that design choice or just convenience at the time?

Also, can you explain the zarr folder and contents?

@kmf56
Copy link

kmf56 commented Jul 30, 2023

Has the been any work done on editing memories? I tried to add a memory using an sql editor and I can't get it to trigger in chat (might have something to do with the zarr component?).

I think there is a lot of potential here to use this as a smart character-specific world info book, and also as a place to store conversation summaries that can be assigned to a timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants