Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query param refresh is ignored for byId #150

Open
robstoll opened this issue Dec 18, 2021 · 0 comments
Open

query param refresh is ignored for byId #150

robstoll opened this issue Dec 18, 2021 · 0 comments
Assignees
@robstoll
Labels
Bug

Comments

@robstoll
Copy link
Contributor

Which means one cannot longer refresh the fountain in proximap as we already dropped byCoords there and we want to do the same here as well. In any case, byId should also check if refresh is defined or not and not always check the cache
@robstoll robstoll added the Bug label Dec 18, 2021
@robstoll robstoll self-assigned this Dec 18, 2021
@robstoll robstoll added this to Board Dec 18, 2021
@robstoll robstoll moved this to In Progress in Board Dec 18, 2021
robstoll added a commit to tegonal/datablue that referenced this issue Dec 20, 2021
@robstoll
water-fountains#150 support forceRefresh byId
2d3b922 
moreover:
- fix getSingleBooleanQueryParam: looks like it is not always
  automatically parsed as boolean
- cleanup eslint, no-unused-vars was duplicated resulting in undesired
  compile error
robstoll added a commit to tegonal/datablue that referenced this issue Dec 20, 2021
@robstoll
water-fountains#150 support forceRefresh byId
7acb2bc 
moreover:
- fix getSingleBooleanQueryParam: looks like it is not always
  automatically parsed as boolean
- cleanup eslint, no-unused-vars was duplicated resulting in undesired
  compile error
@robstoll robstoll moved this from In Progress to Verify in Board Dec 20, 2021
robstoll added a commit that referenced this issue Dec 20, 2021
@robstoll
Merge pull request #152 from tegonal/#150-forceRefresh-id
997d711 
#150 support forceRefresh byId
robstoll added a commit to tegonal/datablue that referenced this issue Dec 20, 2021
@robstoll
water-fountains#150 remove controller.reprocessFountainAtCoords typec…
40bcc5c 
…heck city

moreover:
- rename generateLocationData to generateCityData
robstoll added a commit to tegonal/datablue that referenced this issue Dec 20, 2021
@robstoll
water-fountains#150 remove controller.reprocessFountainAtCoords typec…
38335e9 
…heck city

moreover:
- rename generateLocationData to generateCityData
robstoll added a commit that referenced this issue Dec 20, 2021
@robstoll
Merge pull request #153 from tegonal/#150-forceRefresh-id
84e7296 
#150 remove controller.reprocessFountainAtCoords typecheck city
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robstoll robstoll

Labels
Bug
Projects
Board
Status: Verify
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robstoll