Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String not getting recognized #131

Closed
sivaramaaa opened this issue Dec 12, 2018 · 8 comments
Closed

String not getting recognized #131

sivaramaaa opened this issue Dec 12, 2018 · 8 comments
Labels

Comments

@sivaramaaa
Copy link
Contributor

r2dec was unable to resolve a string (see the argument to puts)

screenshot from 2018-12-12 20-11-14

While r2 has resolved the string properly !

screenshot from 2018-12-12 20-11-47

@sivaramaaa
Copy link
Contributor Author

@wargio if u could give me some pointers , i will try to solve this issue :)

@wargio
Copy link
Owner

wargio commented Dec 12, 2018

is it in izz?

@sivaramaaa
Copy link
Contributor Author

no it's not prsent in izz , i think it's because it's preent in .rodata or something ...

screenshot from 2018-12-13 08-46-30

afaik r2 doest not depend only on izz rather it tries to decode the address and if it's a valid string it put's them as comment

imho it would be nice if r2dec also does the same way to decode the address and check if it's a valid string !

@wargio
Copy link
Owner

wargio commented Dec 13, 2018

the issue is that i cannot know when a comment is a string or when it is not

@sivaramaaa
Copy link
Contributor Author

@wargio yup i understand that , cant we do this from r2dec side , else i can fill an feature request in radare2 issues

@wargio
Copy link
Owner

wargio commented Dec 14, 2018

yup

@wargio
Copy link
Owner

wargio commented Dec 14, 2018

btw, you can identify the string by decreasing the minimal string search size

@wargio wargio added the bug label Dec 19, 2018
@wargio
Copy link
Owner

wargio commented Aug 2, 2019

closing this as dup of #173

@wargio wargio closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants