Optimize ProfileSelectWindow #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jona <[email protected]>
…106/SuperCheatedFrostyToolsuite into 2.0.0_ProfileSelectFix
…106/SuperCheatedFrostyToolsuite into 2.0.0_ProfileSelectFix
…106/SuperCheatedFrostyToolsuite into 2.0.0_ProfileSelectFix
…106/SuperCheatedFrostyToolsuite into 2.0.0_ProfileSelectFix
wannkunstbeikor
requested changes
Oct 19, 2023
| @@ -31,6 +33,52 @@ public ProfileConfig(string inKey) | |||
| Key = inKey; | |||
| Path = Config.Get("GamePath", string.Empty, ConfigScope.Game, Key); | |||
| Name = ProfilesLibrary.GetDisplayName(Key) ?? Key; | |||
| Icon = BitmapAssetValueConverter.Instance.Convert($"avares://FrostyEditor/Assets/Profiles/Icons/{ProfilesLibrary.GetInternalName(inKey)}.png"); | |||
There was a problem hiding this comment.
the icon/banner should probably be in a folder which the user can add, since profiles should be added through the user
There was a problem hiding this comment.
user should can add banner manually?
can u see this? I think it would be better to make the banner part of the theme
| Foreground="{DynamicResource DockThemeForegroundBrush}" | ||
| Background="{x:Null}" | ||
| BorderThickness="1" BorderBrush="{DynamicResource DockThemeBorderLowBrush}" | ||
| ExtendClientAreaToDecorationsHint="True" |
There was a problem hiding this comment.
this does not work on linux, so i think it would be best to just have the title in the window decorations
There was a problem hiding this comment.
just have the title in the window decorations
will cause this in win11, i will try make auto detect windows and custom titlebar in ThemeSystem
|
btw the AcrylicBorder in MainWindow looks so weird (i didnt change that) And im working on ThemeSystem first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old pr