chore(weave): Fixes dedicates instance connection issues with traces API #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylerz
changed the title
wylerz
changed the title
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=528c0b061d33d8f23c7fac7856779df84ddb2ae4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The URL generation logic correctly handles default
https://api.wandb.aiurl by changing trace url tohttps://trace.wandb.ai, but for non default hosts it fails to define traces url correctly (just useshttps://${resolvedHost}).Fix is to append
/tracesto the url for non default hosts.