Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.5 doesn't compile anymore after #26 #27

Open
Popolon opened this issue Nov 24, 2024 · 3 comments
Open

v1.1.5 doesn't compile anymore after #26 #27

Popolon opened this issue Nov 24, 2024 · 3 comments

Comments

@Popolon
Copy link

Popolon commented Nov 24, 2024

After resolution of #26, the package the header cdjpeg.h is missing:

gcc -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto -ffat-lto-objects -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/build/python/src=/usr/src/debug/python -flto=auto -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/home/popolon/.cache/yay/python-mozjpeg-lossless-optimization/src=/usr/src/debug/python-mozjpeg-lossless-optimization -flto=auto -fPIC -I/home/popolon/.cache/yay/python-mozjpeg-lossless-optimization/src/mozjpeg-lossless-optimization-1.1.5/mozjpeg_lossless_optimization -I/home/popolon/.cache/yay/python-mozjpeg-lossless-optimization/src/mozjpeg-lossless-optimization-1.1.5/mozjpeg_lossless_optimization/../mozjpeg -I/home/popolon/.cache/yay/python-mozjpeg-lossless-optimization/src/mozjpeg-lossless-optimization-1.1.5/mozjpeg_lossless_optimization/../mozjpeg/build -I/usr/include/python3.12 -c build/temp.linux-x86_64-cpython-312/mozjpeg_lossless_optimization._mozjpeg_opti.c -o build/temp.linux-x86_64-cpython-312/build/temp.linux-x86_64-cpython-312/mozjpeg_lossless_optimization._mozjpeg_opti.o
build/temp.linux-x86_64-cpython-312/mozjpeg_lossless_optimization._mozjpeg_opti.c:574:10: fatal error: ../mozjpeg/cdjpeg.h: No such file or directory
  574 | #include "../mozjpeg/cdjpeg.h"
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: command '/usr/bin/gcc' failed with exit code 1
@flozz
Copy link
Member

flozz commented Nov 25, 2024

Hello,
It seems the source tarball generated by GitHub does not contain the mozjpeg source code because it is a submodule (so it is not a part of this repository).

You can build from Python sdist package (source distribution package), you should have the mozjpeg sources properly included here:

@Popolon
Copy link
Author

Popolon commented Nov 25, 2024

Hello,

I think this kind of complex link is maybe not really adapted to Arch Linux philosophy?

Maybe the mozjpeg lib should be a dependency, I preparee package for that, and this python module should use reference to standard libs path?

arch Mozjpeg packages depends itself of nasm. I'm afrait it will not be very portable. It also include libjpeg, libturbojpeg, djpeg, jpegtran, instead of linking the from system versions :(. This package at the end install libjpeg and ask to remove more efficient libjpeg-turbo 🤪. I prefer to not maintain anymore this package, and orphean it, very sorry.

@flozz
Copy link
Member

flozz commented Nov 25, 2024

If the link is the only problem, I may upload the sdist package in the github release if it can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants