Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find command too restrictive with multiple inputs #7

Open
wamps-jp opened this issue Nov 17, 2023 · 1 comment
Open

find command too restrictive with multiple inputs #7

wamps-jp opened this issue Nov 17, 2023 · 1 comment

Comments

@wamps-jp
Copy link
Owner

wamps-jp commented Nov 17, 2023

The find command only works if all searched inputs (such as n/ or p/) are present in the final entry.

Calling find n/bernice p/999 on the below example will find no entries:

image.png

image.png

I believe this is too restrictive for many users, who may want to find multiple employees via multiple fields.

While this function is likely working as intended, I believe this functionality is quite useful.

@soc-pe-bot
Copy link

soc-pe-bot commented Nov 20, 2023

Team's Response

Thank you for your input. We acknowledge that having an OR search across multiple attributes can be useful at times but we felt that the more frequently used way is for HR staff members to want to use an AND search across multiple attributes. i.e. HR staff members would likely want to find an employee who has the name Alex and phone number 999 rather than employees with either the name Alex or phone number 999. We feel that this is not in scope because we specified in the UG that the find command finds employees whose attributes satisfy all the search parameters. i.e. AND search and we also feel that adding the OR search is less important than implementing the AND search.

Screenshot 2023-11-19 at 7.33.10 PM.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants