You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a suggestion for naming parameters. Some of them are a little confusing in the ratioOverlap() because it is possible that parameter 'r' is a polygon and parameter 'shp' could be a raster. I suggest changing to 'x' and 'y' (which is common in R functions that take two inputs). In R, the 'r' parameter is usually used to denote raster data, and 'shp' is for shapefiles. If accepted the suggestion, this means that some documentation and vignettes need to be changed.
Best,
Gonzalo
The text was updated successfully, but these errors were encountered:
Hi Gonzalo this is a great idea. Hopefully Cory can add you as a contributor so you can make the changes happy to add it to the vignette when it is done and also probably we will have to check if it affects Wallace integration.
This is a suggestion for naming parameters. Some of them are a little confusing in the ratioOverlap() because it is possible that parameter 'r' is a polygon and parameter 'shp' could be a raster. I suggest changing to 'x' and 'y' (which is common in R functions that take two inputs). In R, the 'r' parameter is usually used to denote raster data, and 'shp' is for shapefiles. If accepted the suggestion, this means that some documentation and vignettes need to be changed.
Best,
Gonzalo
The text was updated successfully, but these errors were encountered: