Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less confusing parameter names (ratioOverlap) #5

Open
gepinillab opened this issue Mar 3, 2023 · 1 comment
Open

Less confusing parameter names (ratioOverlap) #5

gepinillab opened this issue Mar 3, 2023 · 1 comment

Comments

@gepinillab
Copy link
Member

This is a suggestion for naming parameters. Some of them are a little confusing in the ratioOverlap() because it is possible that parameter 'r' is a polygon and parameter 'shp' could be a raster. I suggest changing to 'x' and 'y' (which is common in R functions that take two inputs). In R, the 'r' parameter is usually used to denote raster data, and 'shp' is for shapefiles. If accepted the suggestion, this means that some documentation and vignettes need to be changed.

Best,
Gonzalo

@andrepazv
Copy link
Member

Hi Gonzalo this is a great idea. Hopefully Cory can add you as a contributor so you can make the changes happy to add it to the vignette when it is done and also probably we will have to check if it affects Wallace integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants