-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests version libs to fix warnings and deprecations #1065
Conversation
It's easier to check the files installed.
It's deprecated in github actions.
Upgrades action to node 20 to fix warnings
When I have free time, I'll add the tests from testman with Workerman v4. Actually fail with Windows and need a bit of work (WIP) Workerman server to return the tests |
Thank you very much @joanhey . I'm not sure how much work it will be to add tests for Workerman v4, and since Workerman v5 is about to be released, I don't want the testing for Workerman v4 to take up too much of your time. |
Are functional tests that work with any runtime.
It's working both versions with the same server file !! Thank you !!
|
With this tests, I fixed some problems in Adapterman, Workerman v4 and v5. |
Thank you for your efforts and contributions! I'm glad to see that these feature tests can work in multiple runtime environments. That's great! |
@walkor
PD: I'll try with the actual names EDIT: It's working OK with that names without any change. |
The same server file from v4 it's working with Workerman v5. https://github.com/joanhey/TestMan/actions/runs/11727346885/job/32668200387?pr=2 |
The people are crazy about unit tests, but are only for domain (app) logic. |
Later we need to run that functional tests with any event loop system. |
One question??
We can change that for RFC3875 compliance
So we have more space to add extra information. Actually Adapterman use it too. PD: Adapterman it's using also PD: added as issue |
#1066 |
Added Workerman v4 and v5 to Testman. But v5 fail in one test (session delete) and perhaps it's a bug in v5, as both use the same server file. Workerman/4 OK Workerman/5 Fail Workerman session code in server Pest code for session delete @walkor can you check it ? Thank you PD: It's working in the session set, and fail in session delete (in the part of setting the session) perhaps is a problem with the cache. PD: Just added Testman in packagist (WIP) for easier testing. Still we need to create a bin |
Okay, I will fix it right away. |
Fixed. |
Working OK !! PD: 👍 create a new version. Like I said these tests work better than the unit tests !! |
mm still another problem. Fixed: #1069 |
v1.6.x work OK with PHP 8.4 (without deprecations)
And add ansi color output to composer in the workflow.
Updated workflow actions.