Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change style of section separators in the demo pages #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change style of section separators in the demo pages #83

wants to merge 2 commits into from

Conversation

waldyrious
Copy link
Owner

  • Change style of section separators in the demo pages: make them stand out as outside the page content flow; use colors that provide adequate contrast (WCAG-compatible)
  • Adjust styling of demo page dividers to work in the reset demo
    • The default font-weight and margin-bottom properties for headings are reset from the typical browser defaults, so they need to be specified explicitly
    • Images get floated, so the section dividers need a clear property

@waldyrious
Change style of section separators in the demo pages
61f97f0
@waldyrious
Adjust styling of demo page dividers to work in the reset demo
e689217 
- The default `font-weight` and `margin-bottom` properties for headings
  are reset from the typical browser defaults,
  so they need to be specified explicitly;
- Images get floated, so the section dividers need a `clear` property.
@waldyrious
Copy link
Owner Author

Before After
image image

@waldyrious
Copy link
Owner Author

I'm not yet sure about this. I'll let it sit for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@waldyrious