Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFIL token doesn't support permit #9

Open
bahadylbekov opened this issue Apr 29, 2023 · 1 comment
Open

WFIL token doesn't support permit #9

bahadylbekov opened this issue Apr 29, 2023 · 1 comment

Comments

@bahadylbekov
Copy link

Hi, I've noticed that WFIL implementation doesn't support permits which makes it harder to use with Multicall-based routers. Any thoughts on replacing the ERC20 token inside with the solmate version?

@wadealexc
Copy link
Owner

Copying over from Slack -

I didn’t add permit because signatures aren’t as easy in FEVM. Wanted to consider how to support BLS and SECPK actors, since they’re also supported by the rest of the WFIL implementation.

It wasn’t an easy thing to add and testing is already tough for FEVM stuff, so it got left out in favor of building something as simple and solid as possible.

Could be something we implement in a future version, though!


Also note, this library is based on solmate. There's a reason I didn't port it over 1:1 - FEVM needs some additional handling for non-EVM addresses in EVM contexts. You can read the README for more details on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants